Bug 216568
| Summary: | run-webkit-tests runs xcodebuild an unnecessary amount of times | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> |
| Component: | Tools / Tests | Assignee: | Kimmo Kinnunen <kkinnunen> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, jbedard, kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=243257 | ||
Tim Horton
PlatformInfo tries to memoize calls to xcodebuild to determine SDKs and Xcode version, but there isn't a singleton PlatformInfo, so it doesn't work.
Fixing this reduces the time to run a single test from ~7 seconds to ~3.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/69377368>
Kimmo Kinnunen
https://github.com/WebKit/WebKit/pull/1941
Tim Horton
kimmo++, thank you for fixing :)
EWS
Committed 252047@main (bac2308618bb): <https://commits.webkit.org/252047@main>
Reviewed commits have been landed. Closing PR #1941 and removing active labels.