Bug 216560

Summary: Clean up lazy frame loading
Product: WebKit Reporter: Rob Buis <rbuis>
Component: FramesAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2020-09-15 09:26:39 PDT
Clean up lazy frame loading
Attachments
Patch (2.53 KB, patch)
2020-09-15 09:29 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (2.79 KB, patch)
2020-09-16 00:13 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (3.06 KB, patch)
2020-09-17 02:29 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-09-15 09:29:25 PDT
Created attachment 408825 [details] Patch
Rob Buis
Comment 2 2020-09-16 00:13:10 PDT
Created attachment 408900 [details] Patch
youenn fablet
Comment 3 2020-09-17 01:14:52 PDT
Comment on attachment 408900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408900&action=review > Source/WebKit/Shared/WebPreferences.yaml:2002 > + humanReadableName: "Lazy Iframe Loading" Should it be spelled IFrame? Ditto above for LazyIFrameLoadingEnabled.
Rob Buis
Comment 4 2020-09-17 02:29:26 PDT
Created attachment 409013 [details] Patch
Rob Buis
Comment 5 2020-09-17 02:51:37 PDT
Comment on attachment 408900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408900&action=review >> Source/WebKit/Shared/WebPreferences.yaml:2002 >> + humanReadableName: "Lazy Iframe Loading" > > Should it be spelled IFrame? > Ditto above for LazyIFrameLoadingEnabled. For the actual web preference I am copying ThirdPartyIframeRedirectBlockingEnabled. To avoid this naming problem I just lowercase to iframe now in the description, like ThirdPartyIframeRedirectBlockingEnabled does.
EWS
Comment 6 2020-09-17 05:12:23 PDT
Committed r267187: <https://trac.webkit.org/changeset/267187> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409013 [details].
Radar WebKit Bug Importer
Comment 7 2020-09-17 05:13:16 PDT
<rdar://problem/69061964>
Note You need to log in before you can comment on or make changes to this bug.