Bug 216527

Summary: preprocessor.pm: Use Cygwin::win_to_posix_path and Cygwin::posix_to_win_path instead of cygpath command
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: BindingsAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, darin, pvollan, stephan.szabo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Fujii Hironori
Reported 2020-09-14 22:22:40 PDT
preprocessor.pm: Use Cygwin::win_to_posix_path and Cygwin::posix_to_win_path instead of cygpath command
Attachments
Patch (2.16 KB, patch)
2020-09-14 22:35 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (2.15 KB, patch)
2020-09-15 13:51 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-09-14 22:35:43 PDT
Created attachment 408794 [details] Patch
Stephan Szabo
Comment 2 2020-09-15 10:38:36 PDT
Comment on attachment 408794 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408794&action=review > Source/WebCore/bindings/scripts/preprocessor.pm:73 > + if ($preprocessorAndFlags[0] =~ "cl.exe") { It seems strange to me to assume that only a cl.exe invocation would be in a windows path. Or that you didn't (for example) have a non-cygwin windows build of clang that might need a windows path to the filename even if the perl being run is cygwin perl.
Fujii Hironori
Comment 3 2020-09-15 12:54:26 PDT
Comment on attachment 408794 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408794&action=review >> Source/WebCore/bindings/scripts/preprocessor.pm:73 >> + if ($preprocessorAndFlags[0] =~ "cl.exe") { > > It seems strange to me to assume that only a cl.exe invocation would be in a windows path. Or that you didn't (for example) have a non-cygwin windows build of clang that might need a windows path to the filename even if the perl being run is cygwin perl. Yup, this code can support only cl.exe and clang-cl.exe for Windows path, others (gcc and g++) for Cygwin path.
Fujii Hironori
Comment 4 2020-09-15 13:12:42 PDT
Comment on attachment 408794 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408794&action=review > Source/WebCore/bindings/scripts/preprocessor.pm:74 > + $preprocessorAndFlags[0] = Cygwin::win_to_posix_path($preprocessorAndFlags[0]); Theoretically, I should always do this part "$preprocessorAndFlags[0] = Cygwin::win_to_posix_path($preprocessorAndFlags[0]);" for Cygwin perl even for cl.exe. Will fix.
Fujii Hironori
Comment 5 2020-09-15 13:51:48 PDT
Created attachment 408857 [details] Patch
Fujii Hironori
Comment 6 2020-09-15 14:43:37 PDT
Comment on attachment 408857 [details] Patch Clearing flags on attachment: 408857 Committed r267101: <https://trac.webkit.org/changeset/267101>
Fujii Hironori
Comment 7 2020-09-15 14:43:41 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-09-15 14:44:15 PDT
<rdar://problem/68942823>
Note You need to log in before you can comment on or make changes to this bug.