Bug 216525

Summary:

[Apple Win] Migrate the first part of SimpleFontData{CG}Win.cpp to FontCoreText.cpp

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

Text

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, mmaxfield, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

216353

Attachments:

Description	Flags
WIP	none
Patch	none
Patch	dino: review+

Description Myles C. Maxfield 2020-09-14 21:17:21 PDT

This is the next step of migrating the Apple Win port off CGFont and on to CTFont.

Comment 1 Myles C. Maxfield 2020-09-14 21:17:47 PDT

Created attachment 408787 [details]
WIP

Comment 2 Myles C. Maxfield 2020-09-14 21:34:33 PDT

Created attachment 408788 [details]
Patch

Comment 3 Myles C. Maxfield 2020-09-15 14:19:14 PDT

Created attachment 408863 [details]
Patch

Comment 4 Dean Jackson 2020-09-15 16:29:46 PDT

Comment on attachment 408863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408863&action=review

> Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp:111
> +    // is *not* fixed pitch. Unbelievable but true.

Add "!"

Comment 5 Myles C. Maxfield 2020-09-15 16:34:56 PDT

Committed r267112: <https://trac.webkit.org/changeset/267112>

Comment 6 Radar WebKit Bug Importer 2020-09-15 16:35:17 PDT

<rdar://problem/68949143>