Bug 216525

Summary: [Apple Win] Migrate the first part of SimpleFontData{CG}Win.cpp to FontCoreText.cpp
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 216353    
Attachments:
Description Flags
WIP
none
Patch
none
Patch dino: review+

Myles C. Maxfield
Reported 2020-09-14 21:17:21 PDT
This is the next step of migrating the Apple Win port off CGFont and on to CTFont.
Attachments
WIP (8.29 KB, patch)
2020-09-14 21:17 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (12.18 KB, patch)
2020-09-14 21:34 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (12.97 KB, patch)
2020-09-15 14:19 PDT, Myles C. Maxfield 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2020-09-14 21:17:47 PDT
Created attachment 408787 [details] WIP
Myles C. Maxfield
Comment 2 2020-09-14 21:34:33 PDT
Created attachment 408788 [details] Patch
Myles C. Maxfield
Comment 3 2020-09-15 14:19:14 PDT
Created attachment 408863 [details] Patch
Dean Jackson
Comment 4 2020-09-15 16:29:46 PDT
Comment on attachment 408863 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408863&action=review > Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp:111 > + // is *not* fixed pitch. Unbelievable but true. Add "!"
Myles C. Maxfield
Comment 5 2020-09-15 16:34:56 PDT
Committed r267112: <https://trac.webkit.org/changeset/267112>
Radar WebKit Bug Importer
Comment 6 2020-09-15 16:35:17 PDT
<rdar://problem/68949143>
Note You need to log in before you can comment on or make changes to this bug.