Summary: | [LFC][FFC] Block box flex items establish block formatting contexts | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
zalan
2020-09-14 16:34:31 PDT
Created attachment 408760 [details]
Patch
Comment on attachment 408760 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408760&action=review > Source/WebCore/layout/layouttree/LayoutBox.h:108 > bool isBlockLevelBox() const; > + bool isBlockBox() const; I think a comment is justified to explain the different between BlockLevelBox and BlockBox (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 408760 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408760&action=review > > > Source/WebCore/layout/layouttree/LayoutBox.h:108 > > bool isBlockLevelBox() const; > > + bool isBlockBox() const; > > I think a comment is justified to explain the different between > BlockLevelBox and BlockBox I can copy&paste them from the .cpp (these are all spec terms btw). Created attachment 408763 [details]
Patch
Committed r267059: <https://trac.webkit.org/changeset/267059> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408763 [details]. |