Bug 216496

Summary: [webkitcorepy] AutoInstaller should work with HomeBrew Python
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, dean_johnson, dewei_zhu, repstein, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch beidson: review+

Jonathan Bedard
Reported 2020-09-14 14:33:14 PDT
The AutoInstaller doesn't work with HomeBrew Python at the moment. I'm pretty sure that the AutoInstaller is broken inside some virtualenvs for the same reason.
Attachments
Patch (2.22 KB, patch)
2020-09-14 14:42 PDT, Jonathan Bedard 		beidson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-09-14 14:36:42 PDT
<rdar://problem/68864294>
Jonathan Bedard
Comment 2 2020-09-14 14:42:30 PDT
Created attachment 408747 [details] Patch
Jonathan Bedard
Comment 3 2020-09-14 14:58:24 PDT
HomeBrew sets a default install prefix which ends up conflicting with --home. We just need to override it when calling setup.py.
Brady Eidson
Comment 4 2020-09-14 15:02:26 PDT
Comment on attachment 408747 [details] Patch (Rubberstamp, but... sure!)
Jonathan Bedard
Comment 5 2020-09-14 16:05:13 PDT
Committed r267056: <https://trac.webkit.org/changeset/267056>
Note You need to log in before you can comment on or make changes to this bug.