Summary: | Remove bogus asserts in FTLLower that assume programs are compiled with sensible speculations | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, fpizlo, ggaren, gskachkov, guijemont, jsc32, keith_miller, mark.lam, msaboff, rmorisset, ross.kirsling, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Saam Barati
2020-09-14 11:25:19 PDT
Created attachment 408731 [details]
patch
Comment on attachment 408731 [details]
patch
r=me. I'm a little sad that this may mean we are allowing a "new" OSR exit loop but I guess we should solve that with a fuzzing flag to try to detect it.
(In reply to Keith Miller from comment #3) > Comment on attachment 408731 [details] > patch > > r=me. I'm a little sad that this may mean we are allowing a "new" OSR exit > loop but I guess we should solve that with a fuzzing flag to try to detect > it. I agree about your fuzzier idea, but nothing about this patch has to do with OSR exit loops. Nothing here proves we would or wouldn’t have a loop Committed r267032: <https://trac.webkit.org/changeset/267032> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408731 [details]. |