Bug 216473

Summary: Move Media in GPU Process flag from internal to experimental
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: REOPENED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jbedard, jer.noble, peng.liu6, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

youenn fablet
Reported 2020-09-14 01:09:59 PDT
Move Media in GPU Process flag from internal to experimental
Attachments
Patch (1.23 KB, patch)
2020-09-14 01:10 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (4.24 KB, patch)
2020-09-14 02:57 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.63 KB, patch)
2020-09-22 00:16 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.59 KB, patch)
2020-09-22 00:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-09-14 01:10:55 PDT
Created attachment 408687 [details] Patch
youenn fablet
Comment 2 2020-09-14 02:57:58 PDT
Created attachment 408697 [details] Patch
youenn fablet
Comment 3 2020-09-16 08:43:57 PDT
ping review
Jonathan Bedard
Comment 4 2020-09-16 08:58:49 PDT
(In reply to youenn fablet from comment #3) > ping review I don't think I'm the right reviewer for this.
Peng Liu
Comment 5 2020-09-18 13:42:47 PDT
Comment on attachment 408697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408697&action=review > Tools/WebKitTestRunner/TestController.cpp:840 > + // All experimental features except: Do we need to move this code section down? After the loop?
youenn fablet
Comment 6 2020-09-19 00:26:30 PDT
Comment on attachment 408697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408697&action=review >> Tools/WebKitTestRunner/TestController.cpp:840 >> + // All experimental features except: > > Do we need to move this code section down? After the loop? No, we want to have options set inside the tests to override the default values. In the future, we could update the WebPrefereneces.yank script to add an option to opt out some of the experimental features.
Radar WebKit Bug Importer
Comment 7 2020-09-21 12:09:07 PDT
<rdar://problem/69318786>
youenn fablet
Comment 8 2020-09-22 00:16:54 PDT
Created attachment 409352 [details] Patch for landing
youenn fablet
Comment 9 2020-09-22 00:36:07 PDT
Created attachment 409354 [details] Patch for landing
EWS
Comment 10 2020-09-22 05:11:02 PDT
Committed r267403: <https://trac.webkit.org/changeset/267403> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409354 [details].
Truitt Savell
Comment 11 2020-09-23 09:04:05 PDT
Reverted r267403 for reason: Caused 50+ Crashes on iOS Debug Committed r267479: <https://trac.webkit.org/changeset/267479>
Note You need to log in before you can comment on or make changes to this bug.