Bug 216464

Summary: Enable WebGL2 by default
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Description Dean Jackson 2020-09-13 12:36:08 PDT
Enable WebGL2 by default
Comment 1 Radar WebKit Bug Importer 2020-09-13 12:38:10 PDT
<rdar://problem/68811378>
Comment 2 Dean Jackson 2020-09-13 12:43:13 PDT
Created attachment 408662 [details]
Patch
Comment 3 Dean Jackson 2020-09-13 12:43:29 PDT
I think Sam or Anders should review this.
Comment 4 Sam Weinig 2020-09-13 12:45:09 PDT
Comment on attachment 408662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408662&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1461
>  WebGL2Enabled:
>    type: bool
> -  defaultValue: false
> +  defaultValue: true
>    humanReadableName: "WebGL 2.0"
>    humanReadableDescription: "WebGL 2 prototype"
>    category: experimental

Not that I actually understand the rules for experimental, but should this still be experimental if it is on by default?
Comment 5 Dean Jackson 2020-09-14 11:04:53 PDT
Comment on attachment 408662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408662&action=review

>> Source/WebKit/Shared/WebPreferences.yaml:1461
>>    category: experimental
> 
> Not that I actually understand the rules for experimental, but should this still be experimental if it is on by default?

The original plan was that experimental features should be off by default, but people also wanted a way to toggle off features that were about to ship. Maybe we need yet another form of feature? "Candidate"?
Comment 6 Dean Jackson 2020-09-14 12:09:21 PDT
Committed r267027: <https://trac.webkit.org/changeset/267027>