Bug 216449

Summary: Clean up AVKitSPI.h
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: MediaAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Fix watchOS build failures none

Peng Liu
Reported 2020-09-12 16:21:07 PDT
Clean up AVKitSPI.h
Attachments
Patch (10.50 KB, patch)
2020-09-12 16:33 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Patch (10.41 KB, patch)
2020-09-12 16:53 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Patch (10.21 KB, patch)
2020-09-14 09:37 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Fix watchOS build failures (2.64 KB, patch)
2020-09-14 17:16 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Peng Liu
Comment 1 2020-09-12 16:33:45 PDT
Created attachment 408627 [details] Patch
Peng Liu
Comment 2 2020-09-12 16:53:13 PDT
Created attachment 408628 [details] Patch
EWS
Comment 3 2020-09-13 14:17:39 PDT
Committed r267004: <https://trac.webkit.org/changeset/267004> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408628 [details].
Radar WebKit Bug Importer
Comment 4 2020-09-13 14:18:15 PDT
<rdar://problem/68814026>
Peng Liu
Comment 5 2020-09-14 08:45:09 PDT
Reverted r267004 for reason: The patch leads to build failures on macOS Catalina Committed r267013: <https://trac.webkit.org/changeset/267013>
Peng Liu
Comment 6 2020-09-14 09:37:41 PDT
Created attachment 408715 [details] Patch
Darin Adler
Comment 7 2020-09-14 11:00:31 PDT
Comment on attachment 408715 [details] Patch You don’t need a new review in a case like this.
Peng Liu
Comment 8 2020-09-14 11:26:47 PDT
(In reply to Darin Adler from comment #7) > Comment on attachment 408715 [details] > Patch > > You don’t need a new review in a case like this. Got it, thanks!
EWS
Comment 9 2020-09-14 14:40:41 PDT
Committed r267041: <https://trac.webkit.org/changeset/267041> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408715 [details].
Peng Liu
Comment 10 2020-09-14 16:56:42 PDT
Reopen this bug to fix a build failure on watchOS.
Peng Liu
Comment 11 2020-09-14 17:16:42 PDT
Created attachment 408767 [details] Fix watchOS build failures
EWS
Comment 12 2020-09-14 18:27:26 PDT
Committed r267063: <https://trac.webkit.org/changeset/267063> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408767 [details].
Note You need to log in before you can comment on or make changes to this bug.