Bug 216433

Summary: [LFC][IFC] Add support for non-root-inline-box line spacing
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

zalan
Reported 2020-09-12 05:48:01 PDT
when the line spacing comes from a nested inline box.
Attachments
Patch (9.32 KB, patch)
2020-09-12 06:04 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (9.32 KB, patch)
2020-09-12 06:42 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (9.28 KB, patch)
2020-09-12 09:08 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (10.28 KB, patch)
2020-09-12 09:29 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (10.28 KB, patch)
2020-09-12 09:34 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-09-12 06:04:02 PDT
Created attachment 408591 [details] Patch
zalan
Comment 2 2020-09-12 06:42:14 PDT
Created attachment 408592 [details] Patch
Antti Koivisto
Comment 3 2020-09-12 09:05:47 PDT
Comment on attachment 408592 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408592&action=review > Source/WebCore/layout/inlineformatting/InlineLineBox.h:116 > + using InlineBoxMap = HashMap<const Box*, InlineBox*>; > + const InlineBoxMap::ValuesConstIteratorRange inlineBoxList() const { return m_inlineBoxRectMap.values(); } Maybe this can return 'auto' and void defining a type?
zalan
Comment 4 2020-09-12 09:08:54 PDT
Created attachment 408598 [details] Patch
zalan
Comment 5 2020-09-12 09:09:33 PDT
(In reply to Antti Koivisto from comment #3) > Comment on attachment 408592 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408592&action=review > > > Source/WebCore/layout/inlineformatting/InlineLineBox.h:116 > > + using InlineBoxMap = HashMap<const Box*, InlineBox*>; > > + const InlineBoxMap::ValuesConstIteratorRange inlineBoxList() const { return m_inlineBoxRectMap.values(); } > > Maybe this can return 'auto' and void defining a type? Yeah, it works! It's so much better! Thanks.
zalan
Comment 6 2020-09-12 09:29:15 PDT
Created attachment 408599 [details] Patch
zalan
Comment 7 2020-09-12 09:34:42 PDT
Created attachment 408600 [details] Patch
EWS
Comment 8 2020-09-12 10:07:42 PDT
Committed r266978: <https://trac.webkit.org/changeset/266978> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408600 [details].
Radar WebKit Bug Importer
Comment 9 2020-09-12 10:08:16 PDT
<rdar://problem/68769707>
Note You need to log in before you can comment on or make changes to this bug.