Summary: | Let webkitDisplayingFullscreen() return true when a video element’s fullscreen mode is not VideoFullscreenModeNone | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Peng Liu <peng.liu6> | ||||||||||||||||
Component: | Media | Assignee: | Peng Liu <peng.liu6> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=218208 | ||||||||||||||||||
Bug Depends on: | 216287 | ||||||||||||||||||
Bug Blocks: | |||||||||||||||||||
Attachments: |
|
Description
Peng Liu
2020-09-11 17:07:37 PDT
Created attachment 408890 [details]
WIP patch v0
Created attachment 408935 [details]
WIP patch v1
Created attachment 409091 [details]
WIP patch v2
Created attachment 409104 [details]
WIP patch v3
Created attachment 409156 [details]
Update changelogs
Created attachment 411804 [details]
Rebase the patch
Comment on attachment 411804 [details] Rebase the patch View in context: https://bugs.webkit.org/attachment.cgi?id=411804&action=review > Source/WebCore/html/HTMLMediaElement.cpp:5936 > + if (mode == VideoFullscreenModeStandard) > + m_waitingToEnterFullscreen = true; It looks like this is the meat of the change. That we only set m_waitingToEnterFullscreen if we're entering "standard" fullscreen. > Source/WebCore/html/HTMLMediaElement.cpp:6016 > + setFullscreenMode(VideoFullscreenModeNone); And this is the second functional part of the change, that when exitFullscreen() is called, we set the fullscreenMode to "none" if the old mode was "standard". This all looks good to me; glad we can write more careful tests through Internals now. Created attachment 412065 [details]
Rebased patch for landing
Committed r268865: <https://trac.webkit.org/changeset/268865> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412065 [details]. |