Bug 216426

Summary: Let webkitDisplayingFullscreen() return true when a video element’s fullscreen mode is not VideoFullscreenModeNone
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: MediaAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218208
Bug Depends on: 216287    
Bug Blocks:    
Attachments:
Description Flags
WIP patch v0
none
WIP patch v1
ews-feeder: commit-queue-
WIP patch v2
none
WIP patch v3
none
Update changelogs
none
Rebase the patch
jer.noble: review+
Rebased patch for landing none

Peng Liu
Reported 2020-09-11 17:07:37 PDT
Let webkitDisplayingFullscreen() return true when a video element’s fullscreen mode is not VideoFullscreenModeNone
Attachments
WIP patch v0 (48.45 KB, patch)
2020-09-15 20:02 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
WIP patch v1 (50.92 KB, patch)
2020-09-16 10:46 PDT, Peng Liu 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP patch v2 (60.69 KB, patch)
2020-09-17 17:20 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
WIP patch v3 (60.86 KB, patch)
2020-09-17 22:31 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Update changelogs (63.26 KB, patch)
2020-09-18 11:49 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Rebase the patch (63.23 KB, patch)
2020-10-19 15:09 PDT, Peng Liu 		jer.noble: review+
DetailsFormatted DiffDiff
Rebased patch for landing (62.40 KB, patch)
2020-10-21 21:53 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Peng Liu
Comment 1 2020-09-11 17:08:30 PDT
<rdar://67790759>
Peng Liu
Comment 2 2020-09-15 20:02:06 PDT
Created attachment 408890 [details] WIP patch v0
Peng Liu
Comment 3 2020-09-16 10:46:42 PDT
Created attachment 408935 [details] WIP patch v1
Peng Liu
Comment 4 2020-09-17 17:20:28 PDT
Created attachment 409091 [details] WIP patch v2
Peng Liu
Comment 5 2020-09-17 22:31:49 PDT
Created attachment 409104 [details] WIP patch v3
Peng Liu
Comment 6 2020-09-18 11:49:23 PDT
Created attachment 409156 [details] Update changelogs
Peng Liu
Comment 7 2020-10-19 15:09:39 PDT
Created attachment 411804 [details] Rebase the patch
Jer Noble
Comment 8 2020-10-21 13:50:32 PDT
Comment on attachment 411804 [details] Rebase the patch View in context: https://bugs.webkit.org/attachment.cgi?id=411804&action=review > Source/WebCore/html/HTMLMediaElement.cpp:5936 > + if (mode == VideoFullscreenModeStandard) > + m_waitingToEnterFullscreen = true; It looks like this is the meat of the change. That we only set m_waitingToEnterFullscreen if we're entering "standard" fullscreen. > Source/WebCore/html/HTMLMediaElement.cpp:6016 > + setFullscreenMode(VideoFullscreenModeNone); And this is the second functional part of the change, that when exitFullscreen() is called, we set the fullscreenMode to "none" if the old mode was "standard". This all looks good to me; glad we can write more careful tests through Internals now.
Peng Liu
Comment 9 2020-10-21 21:53:50 PDT
Created attachment 412065 [details] Rebased patch for landing
EWS
Comment 10 2020-10-22 08:22:44 PDT
Committed r268865: <https://trac.webkit.org/changeset/268865> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412065 [details].
Note You need to log in before you can comment on or make changes to this bug.