Bug 216402

Summary: [webkitscmpy] Add Contributor object
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215862
https://bugs.webkit.org/show_bug.cgi?id=216404
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2020-09-11 04:26:01 PDT
Create a class which stores information about contributors.
Attachments
Patch (11.62 KB, patch)
2020-09-11 08:41 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.64 KB, patch)
2020-09-15 12:40 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-09-11 04:27:52 PDT
At some point in the future, this class will be populated by contributors.json, but at the moment, this class is just used to parse out a contributor from changelogs.
Radar WebKit Bug Importer
Comment 2 2020-09-11 04:28:11 PDT
<rdar://problem/68702680>
Jonathan Bedard
Comment 3 2020-09-11 04:37:26 PDT
This change is being used to support https://bugs.webkit.org/show_bug.cgi?id=216404
Jonathan Bedard
Comment 4 2020-09-11 08:41:43 PDT
Created attachment 408535 [details] Patch
dewei_zhu
Comment 5 2020-09-15 11:55:47 PDT
Comment on attachment 408535 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408535&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:49 > +version = Version(0, 0, 5) why do we bump version number by 2?
Jonathan Bedard
Comment 6 2020-09-15 12:26:59 PDT
(In reply to dewei_zhu from comment #5) > Comment on attachment 408535 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408535&action=review > > > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:49 > > +version = Version(0, 0, 5) > > why do we bump version number by 2? Because https://bugs.webkit.org/show_bug.cgi?id=216422 was also in-flight.
Jonathan Bedard
Comment 7 2020-09-15 12:31:00 PDT
(In reply to Jonathan Bedard from comment #6) > (In reply to dewei_zhu from comment #5) > > Comment on attachment 408535 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=408535&action=review > > > > > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:49 > > > +version = Version(0, 0, 5) > > > > why do we bump version number by 2? > > Because https://bugs.webkit.org/show_bug.cgi?id=216422 was also in-flight. Now, I forgot to bump the version in that patch, so it turns out that is mistake!
Jonathan Bedard
Comment 8 2020-09-15 12:40:34 PDT
Created attachment 408845 [details] Patch for landing
EWS
Comment 9 2020-09-15 13:04:04 PDT
Committed r267096: <https://trac.webkit.org/changeset/267096> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408845 [details].
Note You need to log in before you can comment on or make changes to this bug.