| Summary: | Move _setCookieAcceptPolicy to WKHTTPCookieStore | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ggaren, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2020-09-10 12:35:30 PDT
Created attachment 408471 [details]
Patch
Comment on attachment 408471 [details]
Patch
r=me
In order to adopt this SPI, Safari needs two more things: 1. An optional initial cookie accept policy on the WebsiteDataStoreConfiguration. This is mostly used for ephemeral sessions, which would begin with the default cookie accept policy but we want to set it, in this case to be the same as the persistent cookie accept policy. 2. A way to update the cookie accept policies for all website data stores. This could technically be done without SPI, but iterating all existing website data stores is a lot easier in WebKit because we already have nonDefaultDataStores(). I plan to implement this as a class method on WKWebsiteDataStore called something like +_setCookieAcceptPolicyOnAllWebsiteDataStores:completionHandler: I plan to add these with tests in the morning. Just kidding. I think those things are not actually necessary. |