Bug 216362

Summary: Upstream some additional feature defines
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: NEW    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, sam, webkit-bug-importer, wenson_hsieh, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch sam: review+, ews-feeder: commit-queue-

Tim Horton
Reported 2020-09-10 07:31:02 PDT
Upstream some additional feature defines
Attachments
Patch (2.45 KB, patch)
2020-09-10 07:31 PDT, Tim Horton 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (2.45 KB, patch)
2020-09-10 07:33 PDT, Tim Horton 		sam: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2020-09-10 07:31:52 PDT
Created attachment 408436 [details] Patch
Tim Horton
Comment 2 2020-09-10 07:33:50 PDT
Created attachment 408438 [details] Patch
Sam Weinig
Comment 3 2020-09-10 07:52:52 PDT
Comment on attachment 408438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408438&action=review > Source/WTF/wtf/PlatformHave.h:760 > +#define HAVE_SESSION_CLEANUP 1 This name seems too generic. What API is it wrapping? > Source/WTF/wtf/PlatformHave.h:772 > +#define HAVE_QUICKBOARD_COLLECTION_VIEWS 1 Does Quickboard (whatever that is) have a prefix (NS,UI, etc.) that it uses?
Tim Horton
Comment 4 2020-09-10 10:30:05 PDT
(In reply to Sam Weinig from comment #3) > Comment on attachment 408438 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408438&action=review > > > Source/WTF/wtf/PlatformHave.h:760 > > +#define HAVE_SESSION_CLEANUP 1 > > This name seems too generic. What API is it wrapping? I think it's wrong in more ways than that. It /looks/ like it should be an ENABLE or something (guarding WebKit behavior, not existence of a platform feature) but I can't quite tell what it is. Anyway, the name already exists, I'm just upstreaming its definition :)
Tim Horton
Comment 5 2020-09-10 10:30:55 PDT
Ho boy, activateSessionCleanup is very confused, look at all those #ifdefs. Not gonna try to fix it right now.
Radar WebKit Bug Importer
Comment 6 2020-09-17 07:31:16 PDT
<rdar://problem/69069506>
Note You need to log in before you can comment on or make changes to this bug.