Summary: | Upstream some additional feature defines | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
Status: | NEW --- | ||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, sam, webkit-bug-importer, wenson_hsieh, wilander | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2020-09-10 07:31:02 PDT
Created attachment 408436 [details]
Patch
Created attachment 408438 [details]
Patch
Comment on attachment 408438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408438&action=review > Source/WTF/wtf/PlatformHave.h:760 > +#define HAVE_SESSION_CLEANUP 1 This name seems too generic. What API is it wrapping? > Source/WTF/wtf/PlatformHave.h:772 > +#define HAVE_QUICKBOARD_COLLECTION_VIEWS 1 Does Quickboard (whatever that is) have a prefix (NS,UI, etc.) that it uses? (In reply to Sam Weinig from comment #3) > Comment on attachment 408438 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408438&action=review > > > Source/WTF/wtf/PlatformHave.h:760 > > +#define HAVE_SESSION_CLEANUP 1 > > This name seems too generic. What API is it wrapping? I think it's wrong in more ways than that. It /looks/ like it should be an ENABLE or something (guarding WebKit behavior, not existence of a platform feature) but I can't quite tell what it is. Anyway, the name already exists, I'm just upstreaming its definition :) Ho boy, activateSessionCleanup is very confused, look at all those #ifdefs. Not gonna try to fix it right now. |