Bug 216332

Summary:

Update WPT test harness so that webaudio tests output results that are consistent across different machines

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Audio

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, ryanhaddad, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=161693

Bug Depends on:

Bug Blocks:

212611

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-

Chris Dumez

Reported 2020-09-09 15:43:05 PDT

Unskip some webaudio WPT tests that no longer appear to be flaky.

Attachments
Patch (5.85 KB, patch) 2020-09-09 15:51 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (5.69 KB, patch) 2020-09-10 11:34 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (7.63 KB, patch) 2020-09-10 14:42 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (7.62 KB, patch) 2020-09-14 10:02 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (219.02 KB, patch) 2020-09-16 13:42 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (219.70 KB, patch) 2020-09-16 14:15 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2020-09-09 15:51:29 PDT

Created attachment 408379 [details] Patch

Chris Dumez

Comment 2 2020-09-10 11:34:36 PDT

Created attachment 408464 [details] Patch

Chris Dumez

Comment 3 2020-09-10 14:42:35 PDT

Created attachment 408478 [details] Patch

Chris Dumez

Comment 4 2020-09-14 10:02:04 PDT

Created attachment 408718 [details] Patch

Chris Dumez

Comment 5 2020-09-16 13:42:11 PDT

Created attachment 408953 [details] Patch

Chris Dumez

Comment 6 2020-09-16 14:15:24 PDT

Created attachment 408955 [details] Patch

Geoffrey Garen

Comment 7 2020-09-16 15:12:12 PDT

Comment on attachment 408955 [details] Patch rs=me

EWS

Comment 8 2020-09-16 15:31:50 PDT

Committed r267167: <https://trac.webkit.org/changeset/267167> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408955 [details].

Radar WebKit Bug Importer

Comment 9 2020-09-16 15:32:17 PDT

<rdar://problem/69019030>

Aakash Jain

Comment 10 2020-09-18 04:11:14 PDT

(In reply to EWS from comment #8) > Committed r267167: <https://trac.webkit.org/changeset/267167> This broke following two layout tests on ios-wk2 as also indicated by EWS (in https://ews-build.webkit.org/#/builders/24/builds/25874) - imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html - media/now-playing-status-without-media.html

Chris Dumez

Comment 11 2020-09-18 07:50:21 PDT

(In reply to Aakash Jain from comment #10) > (In reply to EWS from comment #8) > > Committed r267167: <https://trac.webkit.org/changeset/267167> > This broke following two layout tests on ios-wk2 as also indicated by EWS > (in https://ews-build.webkit.org/#/builders/24/builds/25874) > > - > imported/w3c/web-platform-tests/webaudio/the-audio-api/the- > mediaelementaudiosourcenode-interface/ > mediaElementAudioSourceToScriptProcessorTest.html > - media/now-playing-status-without-media.html This patch unskipped a lot of audio tests. Odds are these two either need iOS baselines or need to be reskipped if still flaky. I will check.

Chris Dumez

Comment 12 2020-09-18 08:29:58 PDT

(In reply to Chris Dumez from comment #11) > (In reply to Aakash Jain from comment #10) > > (In reply to EWS from comment #8) > > > Committed r267167: <https://trac.webkit.org/changeset/267167> > > This broke following two layout tests on ios-wk2 as also indicated by EWS > > (in https://ews-build.webkit.org/#/builders/24/builds/25874) > > > > - > > imported/w3c/web-platform-tests/webaudio/the-audio-api/the- > > mediaelementaudiosourcenode-interface/ > > mediaElementAudioSourceToScriptProcessorTest.html I rebaselined this test in: http://trac.webkit.org/r267238 Will monitor to see if it is still flaky or not. > > - media/now-playing-status-without-media.html This one looks green on the flakiness dashboard and looks unrelated to my change.

Note You need to log in before you can comment on or make changes to this bug.