Bug 216329

Summary: [CMake] Use imported targets in find module for libseccomp
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cgarcia, clopez, don.olmstead, ews-watchlist, gyuyoung.kim, pnormand, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2 none

Adrian Perez
Reported 2020-09-09 15:33:56 PDT
SSIA
Attachments
Patch (9.29 KB, patch)
2020-09-09 15:49 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch v2 (9.27 KB, patch)
2020-09-10 00:03 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2020-09-09 15:49:30 PDT
Created attachment 408378 [details] Patch
Konstantin Tokarev
Comment 2 2020-09-09 18:50:15 PDT
Comment on attachment 408378 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408378&action=review > Source/cmake/FindLibseccomp.cmake:55 > +find_package(PkgConfig) find_package(PkgConfig QUIET) find modules should find other modules with QUIET
Adrian Perez
Comment 3 2020-09-10 00:01:50 PDT
(In reply to Konstantin Tokarev from comment #2) > Comment on attachment 408378 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408378&action=review > > > Source/cmake/FindLibseccomp.cmake:55 > > +find_package(PkgConfig) > > find_package(PkgConfig QUIET) > > find modules should find other modules with QUIET You're right; this one slipped in. Thanks for noticing!
Adrian Perez
Comment 4 2020-09-10 00:03:09 PDT
Created attachment 408417 [details] Patch v2
EWS
Comment 5 2020-09-10 10:28:17 PDT
Committed r266833: <https://trac.webkit.org/changeset/266833> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408417 [details].
Radar WebKit Bug Importer
Comment 6 2020-09-10 10:29:17 PDT
<rdar://problem/68650472>
Note You need to log in before you can comment on or make changes to this bug.