Bug 216323

Summary:

kill-old-processes: Avoid calling kill command with empty string with GNU xargs

Product:

WebKit

Reporter:

Lauro Moura <lmoura>

Component:

Tools / Tests

Assignee:

Lauro Moura <lmoura>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, darin, dpino, ews-watchlist, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=216068

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch for landing	none

Description Lauro Moura 2020-09-09 13:35:07 PDT

Currently, the kill-old-processes command to kill python scripts (like run-webkit-tests) has an unchecked "xargs kill" at the end, which may output an error message if there is no such command to be killed (as it is the case most of the time). Linux' version of xargs has the "-r" option which can be used to avoid running the command.

Comment 1 Lauro Moura 2020-09-09 13:38:02 PDT

Created attachment 408362 [details]
Patch

Comment 2 Darin Adler 2020-09-09 14:06:23 PDT

Comment on attachment 408362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408362&action=review

> Tools/ChangeLog:3
> +        kill-old-processes: Avoid calling kill command with empty string

This is a platform-specific bug and fix. On BSD systems like macOS, xargs already doesn’t do this. But on platforms with GNU xargs this "-r" option is needed.

Comment 3 Lauro Moura 2020-09-09 19:33:53 PDT

Created attachment 408402 [details]
Patch for landing

Comment 4 Lauro Moura 2020-09-09 19:35:37 PDT

Committed r266808: <https://trac.webkit.org/changeset/266808>

Comment 5 Radar WebKit Bug Importer 2020-09-09 19:36:20 PDT

<rdar://problem/68612810>

Comment 6 Diego Pino 2020-09-13 22:24:57 PDT

*** Bug 215999 has been marked as a duplicate of this bug. ***