Bug 216314

Summary: [WebRTC] Fix uninitialized fields in FilterAnalyzer::ConsistentFilterDetector, FilterAnalyzer::FilterAnalysisState and InterArrival::TimestampGroup
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebRTCAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/webrtc/issues/detail?id=11918
Attachments:
Description Flags
Patch v1
youennf: review+
Patch for landing none

Description David Kilzer (:ddkilzer) 2020-09-09 09:45:56 PDT
Fix uninitialized fields in FilterAnalyzer::ConsistentFilterDetector, FilterAnalyzer::FilterAnalysisState and InterArrival::TimestampGroup.

This is just a hardening task.

Found by clang static analyzer using the optin.cplusplus.UninitializedObject checker.
Comment 1 David Kilzer (:ddkilzer) 2020-09-09 10:25:23 PDT
Created attachment 408338 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2020-09-09 19:15:49 PDT
Created attachment 408399 [details]
Patch for landing
Comment 3 David Kilzer (:ddkilzer) 2020-09-09 19:16:32 PDT
Comment on attachment 408399 [details]
Patch for landing

Adding cq+ since this patch is identical to "Patch v1" except it includes a local copy of the patch for applying to future upstream merges.
Comment 4 Radar WebKit Bug Importer 2020-09-09 19:17:03 PDT
<rdar://problem/68611826>
Comment 5 EWS 2020-09-09 19:51:45 PDT
Committed r266810: <https://trac.webkit.org/changeset/266810>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408399 [details].