Bug 216310

Summary: WebGL2RenderingContext should use Graphics Context types
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: WebGLAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, jdarpinian, kbr, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
kbr: review+
Patch none

Don Olmstead
Reported 2020-09-09 08:39:09 PDT
Some declarations are using GL instead of GCGL types. There are also some GL_ constants that snuck into the file.
Attachments
Patch (19.80 KB, patch)
2020-09-09 08:47 PDT, Don Olmstead 		kbr: review+
DetailsFormatted DiffDiff
Patch (20.56 KB, patch)
2020-09-10 10:30 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-09-09 08:47:03 PDT
Created attachment 408327 [details] Patch
Kenneth Russell
Comment 2 2020-09-09 11:28:24 PDT
Comment on attachment 408327 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408327&action=review Thanks for fixing this build! r+ with one comment. > Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:2109 > + return GraphicsContextGL::WAIT_FAILED_WIN; We could consider naming this WAIT_FAILED_WEBGL in all cases.
Kenneth Russell
Comment 3 2020-09-09 11:28:53 PDT
+jdarpinian as FYI.
James Darpinian
Comment 4 2020-09-09 15:26:23 PDT
Comment on attachment 408327 [details] Patch Looks good to me, thanks for the fixes!
Don Olmstead
Comment 5 2020-09-10 10:30:09 PDT
Created attachment 408457 [details] Patch
EWS
Comment 6 2020-09-10 11:12:50 PDT
Committed r266840: <https://trac.webkit.org/changeset/266840> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408457 [details].
Radar WebKit Bug Importer
Comment 7 2020-09-10 11:13:20 PDT
<rdar://problem/68653471>
Note You need to log in before you can comment on or make changes to this bug.