Bug 216310 - WebGL2RenderingContext should use Graphics Context types
Summary: WebGL2RenderingContext should use Graphics Context types
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
Keywords: InRadar
Depends on:
Reported: 2020-09-09 08:39 PDT by Don Olmstead
Modified: 2020-09-10 11:13 PDT (History)
11 users (show)

See Also:

Patch (19.80 KB, patch)
2020-09-09 08:47 PDT, Don Olmstead
kbr: review+
Details | Formatted Diff | Diff
Patch (20.56 KB, patch)
2020-09-10 10:30 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-09-09 08:39:09 PDT
Some declarations are using GL instead of GCGL types. There are also some GL_ constants that snuck into the file.
Comment 1 Don Olmstead 2020-09-09 08:47:03 PDT
Created attachment 408327 [details]
Comment 2 Kenneth Russell 2020-09-09 11:28:24 PDT
Comment on attachment 408327 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=408327&action=review

Thanks for fixing this build! r+ with one comment.

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:2109
> +        return GraphicsContextGL::WAIT_FAILED_WIN;

We could consider naming this WAIT_FAILED_WEBGL in all cases.
Comment 3 Kenneth Russell 2020-09-09 11:28:53 PDT
+jdarpinian as FYI.
Comment 4 James Darpinian 2020-09-09 15:26:23 PDT
Comment on attachment 408327 [details]

Looks good to me, thanks for the fixes!
Comment 5 Don Olmstead 2020-09-10 10:30:09 PDT
Created attachment 408457 [details]
Comment 6 EWS 2020-09-10 11:12:50 PDT
Committed r266840: <https://trac.webkit.org/changeset/266840>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408457 [details].
Comment 7 Radar WebKit Bug Importer 2020-09-10 11:13:20 PDT