Summary: | WebCore UnifiedSource81 builds for upwards of 10 minutes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, bdakin, benjamin, calvaris, ews-watchlist, ggaren, keith_miller, simon.fraser, webkit-bug-importer, wenson_hsieh, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2020-09-08 17:13:42 PDT
Created attachment 408289 [details]
Patch
I suppose we need to restrict to clang only. Created attachment 408291 [details]
Patch
Comment on attachment 408291 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408291&action=review > Source/WebCore/bindings/js/WebCoreBuiltinNames.h:463 > + // FIXME: Remove the __attribute__((nodebug)) when <rdar://68246686> is fixed. Fixed in all versions that we are building with... (In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 408291 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408291&action=review > > > Source/WebCore/bindings/js/WebCoreBuiltinNames.h:463 > > + // FIXME: Remove the __attribute__((nodebug)) when <rdar://68246686> is fixed. > > Fixed in all versions that we are building with... Sure, or we can add conditional flags (I suppose I could have done that here, too, but I was too lazy to figure it out). Committed r266768: <https://trac.webkit.org/changeset/266768> |