Bug 216296

Summary: Regression(r260614) Power usage has increased due to extra thread hopping
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, nham, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216195
Bug Depends on:    
Bug Blocks: 208778    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2020-09-08 17:06:21 PDT 
Power usage has increased after 260614 due to extra thread hopping.
Comment 1 Chris Dumez 2020-09-08 17:06:33 PDT 
<rdar://problem/67719299>
Comment 2 Chris Dumez 2020-09-08 17:11:20 PDT 
Created attachment 408288 [details]
Patch
Comment 3 Chris Dumez 2020-09-08 17:17:52 PDT 
Created attachment 408290 [details]
Patch
Comment 4 Simon Fraser (smfr) 2020-09-08 17:52:50 PDT 
Comment on attachment 408290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408290&action=review

> Source/WebKit/UIProcess/mac/DisplayLink.h:68
> +    static bool m_shouldSendIPCOnBackgroundQueue;

Should we use s_ for a static?
Comment 5 Chris Dumez 2020-09-08 17:57:11 PDT 
Created attachment 408297 [details]
Patch
Comment 6 EWS 2020-09-08 21:12:38 PDT 
Committed r266771: <https://trac.webkit.org/changeset/266771>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408297 [details].