Bug 216284

Summary: AudioParam.linearRampToValueAtTime() / exponentialRampToValueAtTime() have no effect when there is no preceding event
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611, 216288    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2020-09-08 14:27:23 PDT
AudioParam.linearRampToValueAtTime() / exponentialRampToValueAtTime() have no effect when there is no preceding event in the timeline. This is incorrect. We should insert an implicit SetValue event in the timeline if the ramp event is the first one.
Attachments
Patch (14.68 KB, patch)
2020-09-08 15:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-09-08 15:23:13 PDT
Created attachment 408273 [details] Patch
Chris Dumez
Comment 2 2020-09-08 15:41:57 PDT
Comment on attachment 408273 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408273&action=review > LayoutTests/imported/w3c/ChangeLog:8 > + * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-connections-expected.txt: Fixing via https://bugs.webkit.org/show_bug.cgi?id=216288.
Chris Dumez
Comment 3 2020-09-09 10:49:21 PDT
Comment on attachment 408273 [details] Patch Patch is ready for review.
Chris Dumez
Comment 4 2020-09-09 11:00:35 PDT
Comment on attachment 408273 [details] Patch Clearing flags on attachment: 408273 Committed r266788: <https://trac.webkit.org/changeset/266788>
Chris Dumez
Comment 5 2020-09-09 11:00:37 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-09-09 11:01:16 PDT
<rdar://problem/68584175>
Note You need to log in before you can comment on or make changes to this bug.