Bug 216255

Summary: [WebIDL] Add support for partial interface mixins
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, annulen, cdumez, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kangil.han, kondapallykalyan, macpherson, menard, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Sam Weinig 2020-09-07 15:23:04 PDT
[WebIDL] Add support for partial interface mixins
Comment 1 Sam Weinig 2020-09-07 19:00:06 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-09-08 10:15:01 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-09-08 10:38:49 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-09-08 12:27:51 PDT
Created attachment 408254 [details]
Patch
Comment 5 Darin Adler 2020-09-08 12:50:41 PDT
Comment on attachment 408254 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408254&action=review

> Source/WebCore/ChangeLog:35
> +        Move logic to avoid genertion of mixins and partial here.

generation typo here

> Source/WebCore/bindings/scripts/CodeGenerator.pm:212
> +    ${cppName} at every build. This file must not be tried to compile.

You replicated the tortured grammar: "This file must not be tried to compile." Let's just leave that worthless sentence out?
Comment 6 Sam Weinig 2020-09-08 14:11:17 PDT
Created attachment 408267 [details]
Patch
Comment 7 EWS 2020-09-08 14:46:14 PDT
Committed r266753: <https://trac.webkit.org/changeset/266753>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408267 [details].
Comment 8 Radar WebKit Bug Importer 2020-09-08 14:47:16 PDT
<rdar://problem/68531306>