Bug 216231

Summary:

[WebIDL] Add mode to preprocess-idls.pl to validate fast regex based scanner with the normal IDL parser

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, cdumez, darin, ews-watchlist, glenn, gyuyoung.kim, jbedard, ryuan.choi, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Sam Weinig

Reported 2020-09-06 15:11:47 PDT

[WebIDL] Add mode to preprocess-idls.pl to validate fast regex based scanner with the normal IDL parser

Attachments
Patch (42.35 KB, patch) 2020-09-06 15:39 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (42.82 KB, patch) 2020-09-06 16:03 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (40.46 KB, patch) 2020-09-06 16:05 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2020-09-06 15:14:36 PDT

I keep finding myself running into issues with preprocess-idls.pl, mostly due to its very optimistic parsing of IDL files not matching the actual IDL grammar. One day, I would like to remove this alternative parsing, but as a first step, I want to add a mode I can run preprocess-idls.pl in that uses the real IDL parser to validate that the regex based one is getting the right results.

Sam Weinig

Comment 2 2020-09-06 15:39:16 PDT Comment hidden (obsolete)

Created attachment 408144 [details] Patch

Sam Weinig

Comment 3 2020-09-06 15:42:09 PDT

Oh bummer, looks like I can't 'use experimental 'smartmatch';'

Sam Weinig

Comment 4 2020-09-06 16:03:46 PDT Comment hidden (obsolete)

Created attachment 408148 [details] Patch

Sam Weinig

Comment 5 2020-09-06 16:05:24 PDT

Created attachment 408149 [details] Patch