Bug 216226

Summary: Build failure; cannot find seccomp.h
Product: WebKit Reporter: Mike Gorse <mgorse>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, bugs-noreply, darin, ews-watchlist, gyuyoung.kim, mgorse, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
Patch.
darin: review+, ews-feeder: commit-queue-
Patch. none

Mike Gorse
Reported 2020-09-06 07:47:05 PDT
I am getting a build failure with webkitgtk 2.29.92 where g++ cannot find seccomp.h when BubblewrapLauncher.cpp tries to include it. It looks as though LIBSECCOMP_INCLUDE_DIRS just isn't being added to WebKit_SYSTEM_INCLUDE_DIRECTORIES, so I'm not sure why I'm seeing a failure now where I wasn't with 2.28.4.
Attachments
Patch. (1.07 KB, patch)
2020-09-06 09:29 PDT, Mike Gorse 		darin: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch. (1.08 KB, patch)
2020-09-07 07:03 PDT, Mike Gorse 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike Gorse
Comment 1 2020-09-06 09:29:58 PDT
Created attachment 408123 [details] Patch.
EWS
Comment 2 2020-09-06 14:24:52 PDT
ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.
Mike Gorse
Comment 3 2020-09-07 07:03:55 PDT
Created attachment 408177 [details] Patch.
Darin Adler
Comment 4 2020-09-07 09:47:14 PDT
Comment on attachment 408177 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=408177&action=review > Source/WebKit/ChangeLog:8 > + No new tests (build fix only). Next time you contribute a patch like this you are welcome to just delete this line altogether.
EWS
Comment 5 2020-09-07 10:02:45 PDT
Committed r266702: <https://trac.webkit.org/changeset/266702> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408177 [details].
Adrian Perez
Comment 6 2020-09-09 15:06:11 PDT
It would have been nice to convert the CMake find module for libseccomp to use imported targets while at it… anyway—next time, thanks for writing the patch, Mike!
Note You need to log in before you can comment on or make changes to this bug.