Bug 216221

Summary: [LFC][IFC] LineBox should contain all inline boxes
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Attachments
Patch (29.13 KB, patch)
2020-09-05 21:14 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (66.14 KB, patch)
2020-09-06 06:31 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (33.83 KB, patch)
2020-09-06 10:13 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (35.06 KB, patch)
2020-09-06 11:22 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-09-05 21:14:27 PDT
Created attachment 408112 [details] Patch
zalan
Comment 2 2020-09-06 06:31:23 PDT
Created attachment 408122 [details] Patch
zalan
Comment 3 2020-09-06 10:13:27 PDT
Created attachment 408124 [details] Patch
Antti Koivisto
Comment 4 2020-09-06 10:25:23 PDT
Comment on attachment 408124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408124&action=review > Source/WebCore/ChangeLog:18 > + In this patch we decouple the line box and the line. > + LineBox: > + - fully contains all the inline boxes, both horizontally and vertically. > + - has only width and height geometry > + - height is not constrained by the line-height property > + - does not have the concept of overflow. > + > + Line: > + - contains the LineBox, but the LineBox can overflow the line, both horizontally and vertically. > + - has position relative to the root block container. > + Could you clarify in the ChangeLog how this decoupling maps to the code changes in the patch? > Source/WebCore/layout/inlineformatting/InlineLineBox.h:51 > +// | ----------------------------------|--------------|---------- Root Inline Box > +// || _____ ___ ___ | | > +// || | / \ / \ | Inline Box | > +// || |_____ | | | | | | ascent > +// || | | | | | | | > +// ||__|________\___/____\___/_________|______________|_______ alignment_baseline Could you make this FOO larger? I can barely see it.
zalan
Comment 5 2020-09-06 11:22:37 PDT
Created attachment 408126 [details] Patch
EWS
Comment 6 2020-09-06 14:32:40 PDT
Committed r266682: <https://trac.webkit.org/changeset/266682> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408126 [details].
Radar WebKit Bug Importer
Comment 7 2020-09-06 14:33:17 PDT
<rdar://problem/68434349>
Note You need to log in before you can comment on or make changes to this bug.