[LFC][IFC] LineBox should contain all inline boxes

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

see https://bugs.webkit.org/show_bug.cgi?id=215087#c9

[zalan]

Created attachment 408112 [details]
Patch

[zalan]

Created attachment 408122 [details]
Patch

[zalan]

Created attachment 408124 [details]
Patch

[Antti Koivisto]

Comment on attachment 408124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408124&action=review

> Source/WebCore/ChangeLog:18
> +        In this patch we decouple the line box and the line.
> +        LineBox:
> +        - fully contains all the inline boxes, both horizontally and vertically.
> +        - has only width and height geometry
> +        - height is not constrained by the line-height property
> +        - does not have the concept of overflow.
> +
> +        Line:
> +        - contains the LineBox, but the LineBox can overflow the line, both horizontally and vertically.
> +        - has position relative to the root block container.
> +

Could you clarify in the ChangeLog how this decoupling maps to the code changes in the patch?

> Source/WebCore/layout/inlineformatting/InlineLineBox.h:51
> +// | ----------------------------------|--------------|---------- Root Inline Box
> +// ||   _____    ___      ___          |              |
> +// ||  |        /   \    /   \         |  Inline Box  |
> +// ||  |_____  |     |  |     |        |              |    ascent
> +// ||  |       |     |  |     |        |              |
> +// ||__|________\___/____\___/_________|______________|_______ alignment_baseline

Could you make this FOO larger? I can barely see it.

[zalan]

Created attachment 408126 [details]
Patch

[EWS]

Committed r266682: <https://trac.webkit.org/changeset/266682>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408126 [details].

[Radar WebKit Bug Importer]

<rdar://problem/68434349>