Bug 216209

Summary: iOS: <attachment>'s QuickLook thumbnails can appear squished
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, megan_gardner, pdr, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2020-09-04 18:07:52 PDT
iOS: <attachment>'s QuickLook thumbnails can appear squished
Attachments
Patch (33.36 KB, patch)
2020-09-04 18:10 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (34.49 KB, patch)
2020-09-07 21:40 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (34.51 KB, patch)
2020-09-07 21:49 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (35.05 KB, patch)
2020-09-08 10:21 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (35.07 KB, patch)
2020-09-08 10:36 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (35.06 KB, patch)
2020-09-08 11:13 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2020-09-04 18:10:02 PDT
Created attachment 408060 [details] Patch
Tim Horton
Comment 2 2020-09-04 18:10:04 PDT
<rdar://problem/67817706>
Tim Horton
Comment 3 2020-09-07 21:40:14 PDT
Created attachment 408210 [details] Patch
Tim Horton
Comment 4 2020-09-07 21:49:18 PDT
Created attachment 408211 [details] Patch
Tim Horton
Comment 5 2020-09-07 23:55:09 PDT
I understand the WebKit1 failures (need to skip the test), but I don't understand why the <attachment> isn't there in Mojave WK2.
Tim Horton
Comment 6 2020-09-08 10:21:34 PDT
Created attachment 408239 [details] Patch
Tim Horton
Comment 7 2020-09-08 10:36:19 PDT
Created attachment 408240 [details] Patch
Wenson Hsieh
Comment 8 2020-09-08 10:38:47 PDT
Comment on attachment 408240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408240&action=review > LayoutTests/fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html:23 > + let intervalID = setInterval(function () { Nit - maybe you could use `shouldBecomeDifferent` here instead of `setInterval`?
Tim Horton
Comment 9 2020-09-08 11:13:14 PDT
Created attachment 408243 [details] Patch
EWS
Comment 10 2020-09-08 12:47:10 PDT
Committed r266743: <https://trac.webkit.org/changeset/266743> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408243 [details].
Note You need to log in before you can comment on or make changes to this bug.