Bug 216209 - iOS: <attachment>'s QuickLook thumbnails can appear squished
Summary: iOS: <attachment>'s QuickLook thumbnails can appear squished
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-04 18:07 PDT by Tim Horton
Modified: 2020-09-08 12:47 PDT (History)
12 users (show)

See Also:

Attachments
Patch (33.36 KB, patch)
2020-09-04 18:10 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (34.49 KB, patch)
2020-09-07 21:40 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (34.51 KB, patch)
2020-09-07 21:49 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (35.05 KB, patch)
2020-09-08 10:21 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (35.07 KB, patch)
2020-09-08 10:36 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (35.06 KB, patch)
2020-09-08 11:13 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-09-04 18:07:52 PDT 
iOS: <attachment>'s QuickLook thumbnails can appear squished
Comment 1 Tim Horton 2020-09-04 18:10:02 PDT 
Created attachment 408060 [details]
Patch
Comment 2 Tim Horton 2020-09-04 18:10:04 PDT 
<rdar://problem/67817706>
Comment 3 Tim Horton 2020-09-07 21:40:14 PDT 
Created attachment 408210 [details]
Patch
Comment 4 Tim Horton 2020-09-07 21:49:18 PDT 
Created attachment 408211 [details]
Patch
Comment 5 Tim Horton 2020-09-07 23:55:09 PDT 
I understand the WebKit1 failures (need to skip the test), but I don't understand why the <attachment> isn't there in Mojave WK2.
Comment 6 Tim Horton 2020-09-08 10:21:34 PDT 
Created attachment 408239 [details]
Patch
Comment 7 Tim Horton 2020-09-08 10:36:19 PDT 
Created attachment 408240 [details]
Patch
Comment 8 Wenson Hsieh 2020-09-08 10:38:47 PDT 
Comment on attachment 408240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408240&action=review

> LayoutTests/fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html:23
> +    let intervalID = setInterval(function () {

Nit - maybe you could use `shouldBecomeDifferent` here instead of `setInterval`?
Comment 9 Tim Horton 2020-09-08 11:13:14 PDT 
Created attachment 408243 [details]
Patch
Comment 10 EWS 2020-09-08 12:47:10 PDT 
Committed r266743: <https://trac.webkit.org/changeset/266743>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408243 [details].