|Summary:||[Cocoa,HDR] HLS streams with HDR variants will not select HDR.|
|Product:||WebKit||Reporter:||Jer Noble <jer.noble>|
|Component:||New Bugs||Assignee:||Jer Noble <jer.noble>|
|Severity:||Normal||CC:||calvaris, cdumez, changseok, darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, mjs, philipj, sergio, webkit-bug-importer|
|Version:||WebKit Nightly Build|
Description Jer Noble 2020-09-04 17:02:18 PDT
[Cocoa,HDR] HLS streams with HDR variants will not select HDR.
Comment 3 Darin Adler 2020-09-04 17:09:51 PDT
Comment on attachment 408047 [details] Patch Regression testing?
Comment 4 Jer Noble 2020-09-04 17:51:36 PDT
(In reply to Darin Adler from comment #3) > Comment on attachment 408047 [details] > Patch > > Regression testing? It’s hard; I don’t know that we can write a consistent regression test that isn’t flakey here. For one, it’s very hard to determine what variant HLS chooses; AVFoundation goes out of its way to make that difficult. For two, anything we do which _could_ be detectable will perturb HLS’s selection logic. E.g., giving the HDR and SDR variants different sizes would make the selection detectable, but might lead HLS to choose among the smaller or larger variant, rather than the HDR or SDR one. For three, HLS may only switch up to HDR _eventually_, not initially, so the test may end up taking >10s to run, which on the bots means it would be a flakey timeout. I’ll see what I can do; perhaps a stream with very short segment times, like 0.5s each, may make the switching happen quicker.
Comment 8 EWS 2020-09-14 09:20:54 PDT
Tools/Scripts/svn-apply failed to apply attachment 408555 [details] to trunk. Please resolve the conflicts and upload a new patch.