Bug 216194

Summary: [WebIDL] Realign our IDL extended attribute names with those specified in WebIDL
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, benjamin, calvaris, cdumez, cfleizach, changseok, cmarcelo, darin, d, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, glenn, graouts, gyuyoung.kim, hi, hta, jcraig, jdiggs, jer.noble, jiewen_tan, joepeck, kangil.han, kondapallykalyan, macpherson, menard, mifenton, pdr, philipj, sabouhallawa, samuel_white, schenney, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2020-09-04 15:04:58 PDT
[WebIDL] Realign our IDL extended attribute names with those specified in WebIDL
Attachments
Patch (435.68 KB, patch)
2020-09-04 15:16 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (437.44 KB, patch)
2020-09-04 15:23 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (438.01 KB, patch)
2020-09-04 15:31 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (439.34 KB, patch)
2020-09-04 17:21 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (439.16 KB, patch)
2020-09-05 08:44 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (464.89 KB, patch)
2020-09-05 08:53 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-09-04 15:16:50 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2020-09-04 15:23:56 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2020-09-04 15:31:56 PDT Comment hidden (obsolete)
Sam Weinig
Comment 4 2020-09-04 17:21:54 PDT Comment hidden (obsolete)
Sam Weinig
Comment 5 2020-09-05 08:44:34 PDT Comment hidden (obsolete)
Sam Weinig
Comment 6 2020-09-05 08:53:44 PDT
Created attachment 408087 [details] Patch
Sam Weinig
Comment 7 2020-09-05 09:02:09 PDT
This is a big one, but really just renames.
Darin Adler
Comment 8 2020-09-05 09:02:25 PDT
Comment on attachment 408087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408087&action=review Given the “legacy” in LegacyNoInterfaceObject, it’s surprising that it’s so often needed for correct behavior even in relatively new features. Perhaps they erred when naming it? r=me assuming great EWS results > Source/WebCore/bindings/js/JSDOMAbstractOperations.h:35 > +enum class LegacyOverrideBuiltIns { Make this a one-liner? Vertical form not great for a Yes/No.
Sam Weinig
Comment 9 2020-09-05 10:01:46 PDT
(In reply to Darin Adler from comment #8) > Comment on attachment 408087 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408087&action=review > > Given the “legacy” in LegacyNoInterfaceObject, it’s surprising that it’s so > often needed for correct behavior even in relatively new features. Perhaps > they erred when naming it? > It has mostly been replaced with the "mixin interface" construct, which we don't support yet (or at least until later today).
EWS
Comment 10 2020-09-05 10:14:30 PDT
Committed r266662: <https://trac.webkit.org/changeset/266662> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408087 [details].
Radar WebKit Bug Importer
Comment 11 2020-09-05 10:15:20 PDT
<rdar://problem/68399022>
Sam Weinig
Comment 12 2020-09-05 14:38:51 PDT
(In reply to Darin Adler from comment #8) > > Source/WebCore/bindings/js/JSDOMAbstractOperations.h:35 > > +enum class LegacyOverrideBuiltIns { > > Make this a one-liner? Vertical form not great for a Yes/No. Neglected to do this in the commit. Fix up for review at https://bugs.webkit.org/show_bug.cgi?id=216218.
Alexey Shvayka
Comment 13 2020-11-12 09:52:09 PST
*** Bug 210762 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.