| Summary: | [WebXR] Implement XRSession end event | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||
| Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aperez, cgarcia, darin, husseinakor983, pnormand, svillar, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Sergio Villar Senin
2020-09-04 09:23:02 PDT
Created attachment 407984 [details]
Patch
Comment on attachment 407984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407984&action=review > Source/WebCore/Modules/webxr/XRSessionEvent.h:39 > + static Ref<XRSessionEvent> create(const AtomString&, RefPtr<WebXRSession>&&); In new code I suggest we start using the Init structures in our C++ code instead of having multiple constructors and create functions in all our event classes. I tried his and it seemed to come out pretty good but the patch to do it across the board is huge. Comment on attachment 407984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407984&action=review >> Source/WebCore/Modules/webxr/XRSessionEvent.h:39 >> + static Ref<XRSessionEvent> create(const AtomString&, RefPtr<WebXRSession>&&); > > In new code I suggest we start using the Init structures in our C++ code instead of having multiple constructors and create functions in all our event classes. I tried his and it seemed to come out pretty good but the patch to do it across the board is huge. OK, I'll replace it before landing. Committed r266782: <https://trac.webkit.org/changeset/266782> |