Bug 216176

Summary: Web Inspector: Localization: typo in WAI-ARIA string ("[the] element have")
Product: WebKit Reporter: Patrick Angle <pangle>
Component: Web InspectorAssignee: Patrick Angle <pangle>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, drousso, ews-watchlist, inspector-bugzilla-changes, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Patrick Angle 2020-09-04 07:59:24 PDT
"Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA." should be more akin to "Ensure that elements of role \u0022%s\u0022 and \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA."
Comment 1 Patrick Angle 2020-09-04 07:59:50 PDT
<rdar://63757787>
Comment 2 Patrick Angle 2020-09-04 08:29:09 PDT
Created attachment 407976 [details]
Patch
Comment 3 BJ Burg 2020-09-04 08:59:40 PDT
Comment on attachment 407976 [details]
Patch

r=me
Comment 4 EWS 2020-09-04 09:25:19 PDT
Committed r266612: <https://trac.webkit.org/changeset/266612>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407976 [details].
Comment 5 Devin Rousso 2020-09-04 10:14:20 PDT
Comment on attachment 407976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407976&action=review

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:536
> -localizedStrings["Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA.";
> -localizedStrings["Ensure that element of role \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA.";
> +localizedStrings["Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA.";
> +localizedStrings["Ensure that element of role \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA.";

I think these changes are in the wrong direction.  Both of these audits check multiple elements for the required state, and as such the string should really read "Ensure that elements of role \u0022%s\u0022 have required owned elements ...".  So plural "elements" and "have", not singular.  This also matches what the other tests do.
Comment 6 Patrick Angle 2020-09-04 10:25:33 PDT
Comment on attachment 407976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407976&action=review

>> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:536
>> +localizedStrings["Ensure that element of role \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA.";
> 
> I think these changes are in the wrong direction.  Both of these audits check multiple elements for the required state, and as such the string should really read "Ensure that elements of role \u0022%s\u0022 have required owned elements ...".  So plural "elements" and "have", not singular.  This also matches what the other tests do.

Looking at this again I think you are right. I even said so in my problem description, and proceeded in the opposite direction...
Comment 7 Patrick Angle 2020-09-04 10:35:34 PDT
Reopening to attach new patch.
Comment 8 Patrick Angle 2020-09-04 10:35:35 PDT
Created attachment 407996 [details]
Patch
Comment 9 Patrick Angle 2020-09-04 10:51:10 PDT
Created attachment 407997 [details]
Patch
Comment 10 Devin Rousso 2020-09-04 11:13:59 PDT
Comment on attachment 407997 [details]
Patch

r=me
Comment 11 EWS 2020-09-04 11:42:16 PDT
Committed r266624: <https://trac.webkit.org/changeset/266624>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407997 [details].