Bug 216176

Summary: Web Inspector: Localization: typo in WAI-ARIA string ("[the] element have")
Product: WebKit Reporter: Patrick Angle <pangle>
Component: Web InspectorAssignee: Patrick Angle <pangle>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, hi, inspector-bugzilla-changes, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Patrick Angle
Reported 2020-09-04 07:59:24 PDT
"Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA." should be more akin to "Ensure that elements of role \u0022%s\u0022 and \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA."
Attachments
Patch (10.76 KB, patch)
2020-09-04 08:29 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Patch (10.52 KB, patch)
2020-09-04 10:35 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Patch (10.53 KB, patch)
2020-09-04 10:51 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Patrick Angle
Comment 1 2020-09-04 07:59:50 PDT
<rdar://63757787>
Patrick Angle
Comment 2 2020-09-04 08:29:09 PDT
Created attachment 407976 [details] Patch
Blaze Burg
Comment 3 2020-09-04 08:59:40 PDT
Comment on attachment 407976 [details] Patch r=me
EWS
Comment 4 2020-09-04 09:25:19 PDT
Committed r266612: <https://trac.webkit.org/changeset/266612> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407976 [details].
Devin Rousso
Comment 5 2020-09-04 10:14:20 PDT
Comment on attachment 407976 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407976&action=review > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:536 > -localizedStrings["Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA."; > -localizedStrings["Ensure that element of role \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA."; > +localizedStrings["Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."; > +localizedStrings["Ensure that element of role \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."; I think these changes are in the wrong direction. Both of these audits check multiple elements for the required state, and as such the string should really read "Ensure that elements of role \u0022%s\u0022 have required owned elements ...". So plural "elements" and "have", not singular. This also matches what the other tests do.
Patrick Angle
Comment 6 2020-09-04 10:25:33 PDT
Comment on attachment 407976 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407976&action=review >> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:536 >> +localizedStrings["Ensure that element of role \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."; > > I think these changes are in the wrong direction. Both of these audits check multiple elements for the required state, and as such the string should really read "Ensure that elements of role \u0022%s\u0022 have required owned elements ...". So plural "elements" and "have", not singular. This also matches what the other tests do. Looking at this again I think you are right. I even said so in my problem description, and proceeded in the opposite direction...
Patrick Angle
Comment 7 2020-09-04 10:35:34 PDT
Reopening to attach new patch.
Patrick Angle
Comment 8 2020-09-04 10:35:35 PDT
Created attachment 407996 [details] Patch
Patrick Angle
Comment 9 2020-09-04 10:51:10 PDT
Created attachment 407997 [details] Patch
Devin Rousso
Comment 10 2020-09-04 11:13:59 PDT
Comment on attachment 407997 [details] Patch r=me
EWS
Comment 11 2020-09-04 11:42:16 PDT
Committed r266624: <https://trac.webkit.org/changeset/266624> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407997 [details].
Note You need to log in before you can comment on or make changes to this bug.