Summary: | [GStreamer] REGRESSION(r266559): imported/w3c/web-platform-tests/webaudio/the-audio-api/the-destinationnode-interface/destination.html is failing | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Diego Pino <dpino> | ||||||||
Component: | Web Audio | Assignee: | Philippe Normand <pnormand> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | calvaris, cdumez, eric.carlson, ews-watchlist, glenn, jer.noble, peng.liu6, philipj, pnormand, sergio, vjaquez, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Diego Pino
2020-09-04 01:26:34 PDT
To fix this I suppose we should look for Audio/Sink GstDevices and check the channels range in the caps... Created attachment 411739 [details]
Patch
*** Bug 217699 has been marked as a duplicate of this bug. *** Comment on attachment 411739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411739&action=review > Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:103 > + WTFLogAlways("AudioDestination::create(%u, %u, %f) - unhandled input channels", numberOfInputChannels, numberOfOutputChannels, sampleRate); Nit. Is this change intended? > Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:207 > + // m_isPlaying = newState >= GST_STATE_PLAYING; Nit. Is this comment useful? > Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:266 > + [](GstAppSink* sink, gpointer userData) -> GstFlowReturn { Looks like a duplicated code block? Can we avoid it? Thanks! Created attachment 411848 [details]
Patch
Created attachment 411850 [details]
Patch
Comment on attachment 411850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411850&action=review > Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:103 > + WTFLogAlways("AudioDestination::create(%u, %u, %f) - unhandled input channels", numberOfInputChannels, numberOfOutputChannels, sampleRate); As Peng Liu asked, is the change to always intentional? Comment on attachment 411850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411850&action=review >> Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:103 >> + WTFLogAlways("AudioDestination::create(%u, %u, %f) - unhandled input channels", numberOfInputChannels, numberOfOutputChannels, sampleRate); > > As Peng Liu asked, is the change to always intentional? Yes, it's matching the cocoa implementation. Committed r268727: <https://trac.webkit.org/changeset/268727> |