Bug 216133

Summary:

Web Inspector: Timelines: record button disappears when UI is narrow

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	hi: review+
[Video] With patch applied	none
Patch	nvasilyev: review-, nvasilyev: commit-queue-
Patch	none

Nikita Vasilyev

Reported 2020-09-03 11:18:43 PDT

<rdar://55875921>

Attachments
Patch (2.11 KB, patch) 2020-09-03 11:21 PDT, Nikita Vasilyev	hi: review+	Details Formatted Diff Diff
[Video] With patch applied (515.41 KB, video/quicktime) 2020-09-03 11:23 PDT, Nikita Vasilyev	no flags	Details
Patch (978 bytes, patch) 2020-09-03 11:31 PDT, Nikita Vasilyev	nvasilyev: review- nvasilyev: commit-queue-	Details Formatted Diff Diff
Patch (2.46 KB, patch) 2020-09-03 11:31 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Nikita Vasilyev

Comment 1 2020-09-03 11:21:43 PDT

Created attachment 407896 [details] Patch

Nikita Vasilyev

Comment 2 2020-09-03 11:23:18 PDT

Created attachment 407898 [details] [Video] With patch applied

Devin Rousso

Comment 3 2020-09-03 11:28:21 PDT

Comment on attachment 407896 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407896&action=review r=me > Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js:49 > + this._recordButton.visibilityPriority = WI.NavigationItem.VisibilityPriority.High; we should also do this to `_continueButton`, as it's shown instead of `_recordButton` when ⌥ is pressed and the active recording will auto-stop (`WI.TimelineTabContentView.prototype._updateNavigationBarButtons`)

Nikita Vasilyev

Comment 4 2020-09-03 11:31:12 PDT Comment hidden (obsolete)

Created attachment 407899 [details] Patch Good point.

Nikita Vasilyev

Comment 5 2020-09-03 11:31:54 PDT

Created attachment 407900 [details] Patch

EWS

Comment 6 2020-09-03 12:17:05 PDT

Committed r266537: <https://trac.webkit.org/changeset/266537> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407900 [details].

Note You need to log in before you can comment on or make changes to this bug.