Bug 216132

Summary: Make AudioParam.cancelScheduledValues() standards compliant
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2020-09-03 11:10:44 PDT
Make AudioParam.cancelScheduledValues() standards compliant.
Attachments
Patch (5.43 KB, patch)
2020-09-03 11:16 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (5.57 KB, patch)
2020-09-03 14:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-09-03 11:16:35 PDT
Created attachment 407895 [details] Patch
Geoffrey Garen
Comment 2 2020-09-03 13:04:30 PDT
Comment on attachment 407895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407895&action=review r=me > Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp:165 > + if (eventTime >= cancelTime || ((m_events[i].type() == ParamEvent::SetValueCurve) > + && eventTime <= cancelTime && (eventTime + m_events[i].duration() > cancelTime))) { This condition clause might read more easily as a helper lambda called as "isAfter(m_events[I], cancelTime)".
Chris Dumez
Comment 3 2020-09-03 14:30:08 PDT
Created attachment 407912 [details] Patch
Chris Dumez
Comment 4 2020-09-03 14:42:49 PDT
Comment on attachment 407912 [details] Patch Clearing flags on attachment: 407912 Committed r266558: <https://trac.webkit.org/changeset/266558>
Chris Dumez
Comment 5 2020-09-03 14:42:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-09-03 14:43:13 PDT
<rdar://problem/68302775>
Note You need to log in before you can comment on or make changes to this bug.