Bug 216099

Summary: Choose adequate number of channels for ConvolverNode's output
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-09-02 14:47:04 PDT
Choose adequate number of channel for ConvolverNode's output. We were using 2 channels for the output no matter what but we're supposed to use a single channel if the both input and the response buffer are mono.
Attachments
Patch (87.03 KB, patch)
2020-09-02 15:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (86.96 KB, patch)
2020-09-02 16:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (86.96 KB, patch)
2020-09-02 16:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (104.39 KB, patch)
2020-09-02 17:15 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (104.51 KB, patch)
2020-09-02 17:22 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-09-02 15:06:20 PDT
Created attachment 407820 [details] Patch
Eric Carlson
Comment 2 2020-09-02 15:56:36 PDT
Comment on attachment 407820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407820&action=review > Source/WebCore/ChangeLog:9 > + the output no matter what but we're supposed to use a single channel if the both input s/if the both/if both the/
Chris Dumez
Comment 3 2020-09-02 16:00:24 PDT
Created attachment 407826 [details] Patch
Chris Dumez
Comment 4 2020-09-02 16:03:35 PDT
Created attachment 407827 [details] Patch
Chris Dumez
Comment 5 2020-09-02 17:15:59 PDT
Created attachment 407835 [details] Patch
Chris Dumez
Comment 6 2020-09-02 17:22:06 PDT
Created attachment 407836 [details] Patch
EWS
Comment 7 2020-09-02 20:22:34 PDT
Committed r266501: <https://trac.webkit.org/changeset/266501> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407836 [details].
Radar WebKit Bug Importer
Comment 8 2020-09-02 20:23:31 PDT
<rdar://problem/68251440>
Note You need to log in before you can comment on or make changes to this bug.