Bug 216094

Summary: Align ISO-8859-{3,6,7,8} and windows-{874,1253} encodings with Chrome, Firefox, and the specification
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, peng.liu6, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch darin: review+

Alex Christensen
Reported 2020-09-02 13:53:04 PDT
Align ISO-8859-{3,6,7,8} and windows-{874,1253} encodings with Chrome, Firefox, and the specification
Attachments
Patch (112.38 KB, patch)
2020-09-02 13:55 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (112.61 KB, patch)
2020-09-02 14:12 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (154.47 KB, patch)
2020-09-02 15:20 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (155.37 KB, patch)
2020-09-02 16:45 PDT, Alex Christensen 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-09-02 13:55:42 PDT
Created attachment 407802 [details] Patch
Alex Christensen
Comment 2 2020-09-02 14:12:22 PDT
Created attachment 407808 [details] Patch
Alex Christensen
Comment 3 2020-09-02 15:20:08 PDT
Created attachment 407821 [details] Patch
Peng Liu
Comment 4 2020-09-02 15:48:47 PDT
Comment on attachment 407821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407821&action=review > Source/WebCore/platform/text/TextCodecSingleByte.cpp:36 > +const UChar iso88593[128] { Use constexpr like others?
Alex Christensen
Comment 5 2020-09-02 16:45:34 PDT
Created attachment 407832 [details] Patch
Alex Christensen
Comment 6 2020-09-03 09:22:34 PDT
Looks like I need to update fast/encoding/char-decoding.html also. Will do.
Alex Christensen
Comment 7 2020-09-03 09:29:58 PDT
Comment on attachment 407832 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407832&action=review > Source/WTF/wtf/PlatformHave.h:740 > +#define HAVE_ICU_WITH_CORRECT_WINDOWS_1255 1 This was optimistic. Big Sur and iOS14 have an ICU that is more correct but not completely correct. I'll remove this and just use the table everywhere.
Alex Christensen
Comment 8 2020-09-03 09:34:16 PDT
http://trac.webkit.org/r266527
Radar WebKit Bug Importer
Comment 9 2020-09-03 09:35:18 PDT
<rdar://problem/68284106>
Note You need to log in before you can comment on or make changes to this bug.