Bug 216072

Summary: Expose RTCPeerConnection.restartIce
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, hta, jer.noble, kondapallykalyan, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2020-09-02 05:44:36 PDT
Expose RTCPeerConnection.restartIce
Attachments
Patch (11.63 KB, patch)
2020-09-02 05:45 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (12.64 KB, patch)
2020-09-02 05:49 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (16.71 KB, patch)
2020-09-02 08:40 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-09-02 05:45:48 PDT
Created attachment 407759 [details] Patch
youenn fablet
Comment 2 2020-09-02 05:49:08 PDT
Created attachment 407760 [details] Patch
youenn fablet
Comment 3 2020-09-02 08:40:37 PDT
Created attachment 407769 [details] Patch
Darin Adler
Comment 4 2020-09-02 10:04:51 PDT
Comment on attachment 407769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407769&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.h:127 > + void restartIce() { m_backend->restartIce(); } No null check needed here?
youenn fablet
Comment 5 2020-09-02 10:11:09 PDT
(In reply to Darin Adler from comment #4) > Comment on attachment 407769 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407769&action=review > > > Source/WebCore/Modules/mediastream/RTCPeerConnection.h:127 > > + void restartIce() { m_backend->restartIce(); } > > No null check needed here? The model is a bit weird right now so we cannot have a UniqueRef, as we would probably like. Basically RTCPeerConnection constructor creates the backend and RTCPeerConnection::create makes sure a peer connection has a backend, or it throws and deallocate the RTCPeerConnection. I can probably refactor this to use a UniqueRef and clarify this.
EWS
Comment 6 2020-09-03 06:24:38 PDT
Committed r266511: <https://trac.webkit.org/changeset/266511> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407769 [details].
Radar WebKit Bug Importer
Comment 7 2020-09-03 06:25:32 PDT
<rdar://problem/68275102>
Note You need to log in before you can comment on or make changes to this bug.