Bug 216044

Summary: [Flatpak SDK] Adapt clean-webkit script to flatpak
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Diego Pino <dpino>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Diego Pino
Reported 2020-09-01 11:18:27 PDT
[Flatpak SDK] Adapt clean-webkit script to flatpak
Attachments
Patch (2.66 KB, patch)
2020-09-01 11:19 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2020-09-01 11:19:49 PDT
Created attachment 407700 [details] Patch
Diego Pino
Comment 2 2020-09-01 11:25:59 PDT
This script, clean-webkit, is used by the EWS in the 'unapply-patch' step. See: https://ews-build.webkit-uat.org/#/builders/34/builds/4962 When passing the '--keep-jhbuild-directory' knob the script deletes everything inside 'WebKitBuild/' except 'DependenciesGTK/' and 'DependenciesWPE/'. Since the EWS bots are using Flatpak, the script removes everything inside 'WebKitBuild/' and the following step 'compile-webkit-without-patch' fails because libwpe dependency is missing.
EWS
Comment 3 2020-09-01 21:50:39 PDT
Committed r266450: <https://trac.webkit.org/changeset/266450> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407700 [details].
Radar WebKit Bug Importer
Comment 4 2020-09-01 21:51:14 PDT
<rdar://problem/68186945>
Note You need to log in before you can comment on or make changes to this bug.