Delete DeprecatedGlobalSettings

• Component: WebCore Misc.
• Status: REOPENED ---

[Sam Weinig]

DeprecatedGlobalSettings has been named deprecated for many years. Let's finish it off, and find new homes for its members.

[Sam Weinig]

Most of the very straightforward ones out of the way, now onto the more complicated ones (only listing the getter half of each):


    static bool shouldUseHighResolutionTimers() { return gShouldUseHighResolutionTimers; }

Windows only, used in platform/win/MainThreadSharedTimerWin.cpp (layering violation).


    static bool isAVFoundationEnabled() { return gAVFoundationEnabled; }

Used in platform/graphics/MediaPlayer.cpp (layering violation).


    static bool isAVFoundationNSURLSessionEnabled() { return gAVFoundationNSURLSessionEnabled; }

Used in platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (layering violation).


    static bool isGStreamerEnabled() { return gGStreamerEnabled; }

Used in platform/graphics/MediaPlayer.cpp (layering violation).


    WEBCORE_EXPORT static bool mockScrollbarsEnabled();

Used in platform/ScrollbarTheme.cpp (layering violation) and testing/InternalSettings.cpp.


    static bool usesOverlayScrollbars();

Used in platform/adwaita/ScrollbarThemeAdwaita.cpp (layering violation), platform/mock/ScrollbarThemeMock.cpp (layering violation), platform/Mac/NSScrollerImpDetails.mm (layering violation) and platform/Mac/ScrollbarThemeMac.mm (layering violation).


    static bool usesMockScrollAnimator();

Used in page/FrameView.cpp, rendering/RenderLayer.cpp, rendering/RenderListBox.cpp. (this one it seems like we could move to Settings.yaml).



    static bool shouldRespectPriorityInCSSAttributeSetters();

Used in css/CSSStyleDeclaration.cpp.


    static bool lowPowerVideoAudioBufferSizeEnabled() { return gLowPowerVideoAudioBufferSizeEnabled; }

Used in platform/audio/cocoa/MediaSessionManagerCocoa.mm (layering violation).


    static bool resourceLoadStatisticsEnabled() { return gResourceLoadStatisticsEnabledEnabled; }

Used in dom/Document.cpp, WebKit/WebProcess/WebProcess.cpp and WebKit/WebProcess/WebPage/WebCookieJar.cpp.


    static unsigned audioSessionCategoryOverride();

Not used anywhere, though setter is, and calls down to AudioSession::sharedSession().setCategoryOverride(...).


    static bool networkDataUsageTrackingEnabled();

Not used anywhere.


    static const String& networkInterfaceName();

Used in WebCore/html/HTMLMediaElement.cpp (this one it seems like we could move to Settings.yaml, probably needs a clearer names, since it is only used for some media related purposes).


    static bool disableScreenSizeOverride() { return gDisableScreenSizeOverride; }

Not used anywhere.


    static bool avKitEnabled() { return gAVKitEnabled; }

Used in WebKit/WebProcess/cocoa/VideoFullscreenManager.mm, WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm and WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (layering violation).


    static bool shouldOptOutOfNetworkStateObservation() { return gShouldOptOutOfNetworkStateObservation; }

Used in WebCore/platform/network/iOS/NetworkStateNotifierIOS.mm (layering violation).


    static bool shouldManageAudioSessionCategory() { return gManageAudioSession; }

Used in WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm (layering violation), WebCore/platform/mediastream/Mac/BaseAudioSharedUnit.cpp (layering violation), and WebCore/testing/InternalSettings.cpp.


    static bool allowsAnySSLCertificate();

Used in WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp (layering violation), WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp (layering violation) and WebKit/NetworkProcess/soup/NetworkSessionSoup.cpp.

[Sam Weinig]

(In reply to Sam Weinig from comment #1)
> 
> 
>     static bool disableScreenSizeOverride() { return
> gDisableScreenSizeOverride; }
> 
> Not used anywhere.

Actually, this one is indeed still used.

[Radar WebKit Bug Importer]

<rdar://problem/68375087>

[Tim Nguyen (:ntim)]

*** This bug has been marked as a duplicate of bug 250192 ***

[Tim Nguyen (:ntim)]

Actually we can use this bug to remove the file itself.