Bug 215948

Summary: [ews] Notify bot watchers about pre-existing and flaky test failures for JSC tests
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215949
https://bugs.webkit.org/show_bug.cgi?id=207475
https://bugs.webkit.org/show_bug.cgi?id=216889
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2020-08-28 13:33:59 PDT
Notify bot watchers about pre-existing and flaky test failures for JSC tests.
Attachments
Patch (3.85 KB, patch)
2020-09-04 04:41 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-09-04 04:41:10 PDT
Created attachment 407958 [details] Patch
Jonathan Bedard
Comment 2 2020-09-04 11:27:05 PDT
Comment on attachment 407958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407958&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:1781 > + def send_email_for_flaky_failure(self, test_name): Same deal as https://bugs.webkit.org/show_bug.cgi?id=215949, the only variability here seems to be the suite, should we consider basing all of these analysis steps on the same base class?
Aakash Jain
Comment 3 2020-09-04 11:42:16 PDT
(In reply to Jonathan Bedard from comment #2) > Same deal as https://bugs.webkit.org/show_bug.cgi?id=215949, the only variability here seems to be the suite, should we consider basing all of these analysis steps on the same base class? Yeah, will do that in a separate patch.
EWS
Comment 4 2020-09-04 11:51:05 PDT
commit-queue failed to commit attachment 407958 [details] to WebKit repository.
EWS
Comment 5 2020-09-04 12:19:48 PDT
Committed r266629: <https://trac.webkit.org/changeset/266629> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407958 [details].
Radar WebKit Bug Importer
Comment 6 2020-09-04 12:20:16 PDT
<rdar://problem/68359434>
Note You need to log in before you can comment on or make changes to this bug.