Bug 21593

Summary:

add multiple-file support to HTMLFormElement

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Forms

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adele, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
patch	sam: review+

Darin Adler

Reported 2008-10-14 11:50:20 PDT

Change the form-submission code in HTMLFormElement to support multiple files. There's no way to test this yet since the HTMLInputElement doesn't yet support selecting multiple files, but I will test that it doesn't cause any regressions or problems for the 0 file or 1 file case.

Attachments
patch (11.75 KB, patch) 2008-10-14 12:00 PDT, Darin Adler	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2008-10-14 12:00:06 PDT

Created attachment 24344 [details] patch

Darin Adler

Comment 2 2008-10-14 12:00:43 PDT

(In reply to comment #0) > I will test that it doesn't cause any regressions or problems for the 0 file or 1 file case. I ran the entire regression test suite and that worked fine. I'll do some manual testing now.

Sam Weinig

Comment 3 2008-10-14 12:08:13 PDT

Comment on attachment 24344 [details] patch Awesome patch. I am a little concerned about the removal of copyright though. How did you verify that those contributors that were removed had no edits to the contents of the files? r=me if you have a good reason for doing so.

Darin Adler

Comment 4 2008-10-14 12:12:55 PDT

(In reply to comment #3) > How did you verify that those contributors that were removed had no edits to > the contents of the files? 1) I wrote all the code for those classes myself. 2) You can easily see by the ChangeLog that code was added in 2005; the other copyrights were from long before 2005.

Darin Adler

Comment 5 2008-10-14 12:19:48 PDT

http://trac.webkit.org/changeset/37589

Note You need to log in before you can comment on or make changes to this bug.