Bug 215924

Summary: [WPE] Enable Notifications support
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WPE WebKitAssignee: Adrian Perez <aperez>
Severity: Normal CC: annulen, aperez, bugs-noreply, cgarcia, clopez, ews-watchlist, gyuyoung.kim, pnormand, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215950
Description Flags
Patch for landing none

Description Philippe Normand 2020-08-28 07:18:03 PDT
Why is this disabled? It doesn't seem to pull additional build-time dependencies here.
Comment 1 Adrian Perez 2020-08-28 07:58:30 PDT
I think we should enable this by default. For the WPE port I think it is
fine to let the default implementation be a stub that does nothing (so
not even libnotify is needed at build time) so embedders can decide how
to show notifications connecting to the WebKitWebView::show-notification
Comment 2 Adrian Perez 2020-08-28 08:46:33 PDT
Created attachment 407471 [details]
Comment 3 Philippe Normand 2020-08-28 08:56:58 PDT
Comment on attachment 407471 [details]

Maybe this could allow us to unskip some of http/tests/notifications ?
Comment 4 Philippe Normand 2020-08-28 08:57:32 PDT
and imported/w3c/web-platform-tests/notifications
Comment 5 Adrian Perez 2020-08-28 09:00:22 PDT
(In reply to Philippe Normand from comment #3)
> Comment on attachment 407471 [details]
> Patch
> Maybe this could allow us to unskip some of http/tests/notifications ?

Probably, I'll give it a try before landing.
Comment 6 Adrian Perez 2020-08-28 14:23:17 PDT
Regarding layout tests:

 - All the tests under http/tests/notifications/ pass.
 - All but one under imported/w3c/web-platform-tests/notifications/ pass, too.
 - imported/w3c/web-platform-tests/notifications/shownotification-resolve-manual.https.html
   gives a timeout, I'll mark it “[ Timeout Pass ]” for now.
Comment 7 Adrian Perez 2020-08-28 14:35:33 PDT
Created attachment 407501 [details]
Patch for landing
Comment 8 EWS 2020-08-28 15:10:00 PDT
Committed r266297: <https://trac.webkit.org/changeset/266297>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407501 [details].