Bug 215924

Summary: [WPE] Enable Notifications support
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WPE WebKitAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, bugs-noreply, cgarcia, clopez, ews-watchlist, gyuyoung.kim, pnormand, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215950
Attachments:
Description Flags
Patch
none
Patch for landing none

Philippe Normand
Reported 2020-08-28 07:18:03 PDT
Why is this disabled? It doesn't seem to pull additional build-time dependencies here.
Attachments
Patch (1.94 KB, patch)
2020-08-28 08:46 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.14 KB, patch)
2020-08-28 14:35 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2020-08-28 07:58:30 PDT
I think we should enable this by default. For the WPE port I think it is fine to let the default implementation be a stub that does nothing (so not even libnotify is needed at build time) so embedders can decide how to show notifications connecting to the WebKitWebView::show-notification signal.
Adrian Perez
Comment 2 2020-08-28 08:46:33 PDT
Created attachment 407471 [details] Patch
Philippe Normand
Comment 3 2020-08-28 08:56:58 PDT
Comment on attachment 407471 [details] Patch Maybe this could allow us to unskip some of http/tests/notifications ?
Philippe Normand
Comment 4 2020-08-28 08:57:32 PDT
and imported/w3c/web-platform-tests/notifications
Adrian Perez
Comment 5 2020-08-28 09:00:22 PDT
(In reply to Philippe Normand from comment #3) > Comment on attachment 407471 [details] > Patch > > Maybe this could allow us to unskip some of http/tests/notifications ? Probably, I'll give it a try before landing.
Adrian Perez
Comment 6 2020-08-28 14:23:17 PDT
Regarding layout tests: - All the tests under http/tests/notifications/ pass. - All but one under imported/w3c/web-platform-tests/notifications/ pass, too. - imported/w3c/web-platform-tests/notifications/shownotification-resolve-manual.https.html gives a timeout, I'll mark it “[ Timeout Pass ]” for now.
Adrian Perez
Comment 7 2020-08-28 14:35:33 PDT
Created attachment 407501 [details] Patch for landing
EWS
Comment 8 2020-08-28 15:10:00 PDT
Committed r266297: <https://trac.webkit.org/changeset/266297> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407501 [details].
Note You need to log in before you can comment on or make changes to this bug.