Bug 215889

Summary: [webkitpy] Use webkitcorepy's auto installer for moz* packages
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, ews-watchlist, glenn, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214950
https://bugs.webkit.org/show_bug.cgi?id=216879
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2020-08-27 09:03:18 PDT
Part of removing webkitpy's autoinstaller in favor of webkitcorepy's.
Attachments
Patch (4.44 KB, patch)
2020-08-27 09:17 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (4.46 KB, patch)
2020-09-21 13:10 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (4.46 KB, patch)
2020-09-21 13:16 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.47 KB, patch)
2020-09-21 13:58 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-08-27 09:03:36 PDT
<rdar://problem/67877935>
Jonathan Bedard
Comment 2 2020-08-27 09:17:26 PDT
Created attachment 407407 [details] Patch
Jonathan Bedard
Comment 3 2020-09-21 13:10:48 PDT
Created attachment 409309 [details] Patch
Jonathan Bedard
Comment 4 2020-09-21 13:16:38 PDT
Created attachment 409311 [details] Patch
Aakash Jain
Comment 5 2020-09-21 13:17:52 PDT
Comment on attachment 409309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409309&action=review rs=me > Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:-31 > -import webkitpy.thirdparty.autoinstalled.mozlog These imports aren't required anymore?
Jonathan Bedard
Comment 6 2020-09-21 13:20:35 PDT
(In reply to Aakash Jain from comment #5) > Comment on attachment 409309 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409309&action=review > > rs=me > > > Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:-31 > > -import webkitpy.thirdparty.autoinstalled.mozlog > > These imports aren't required anymore? They aren't valid any more. The old autoinstaller required that you preface an autoinstalled library with 'webkitpy.thirdparty.autoinstalled' to trigger the auto-instillation. The new one will pick up any import of the library. That means that in this case, "from mozlog import structuredlog" will install mozlog for us.
Jonathan Bedard
Comment 7 2020-09-21 13:58:25 PDT
Created attachment 409317 [details] Patch for landing
EWS
Comment 8 2020-09-21 14:20:22 PDT
Committed r267368: <https://trac.webkit.org/changeset/267368> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409317 [details].
Note You need to log in before you can comment on or make changes to this bug.