Bug 215867

Summary: Ensure that email notifications are not sent for obsolete and r- patches
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Aakash Jain 2020-08-26 13:57:13 PDT
We should ensure that email notifications are not sent for obsolete and r- patches. EWS does check occasionally if the patch is obsolete/r- and stops processing the build if so. However, there aren't checks at the end of the build. If the patch becomes obsolete/r- after EWS checks the patch state, it is possible that EWS might send email notification for the failure. We should add another check just before sending the email, to ensure that EWS doesn't send email for obsolete/r- patches. 

Note that it should be fine to send email for bugs which are closed, since it might indicate that there was a failure on the patch which was landed.
Comment 1 Aakash Jain 2020-08-26 14:00:36 PDT
Created attachment 407337 [details]
Patch
Comment 2 Jonathan Bedard 2020-08-27 14:36:41 PDT
Comment on attachment 407337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407337&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:549
> +            self._addToLog('stdio', 'Skipping email since patch {} is marked r-'.format(patch_id))

Do we have a request somewhere to make this the behavior when a patch is marked r-? It's not obviously that an r- ed patch shouldn't generate notification emails.
Comment 3 Aakash Jain 2020-08-27 15:03:54 PDT
(In reply to Jonathan Bedard from comment #2)
> Do we have a request somewhere to make this the behavior when a patch is marked r-? It's not obviously that an r- ed patch shouldn't generate notification emails.
Not an explicit request. Although marking r- itself generate an email notification from bugzilla.
Comment 4 EWS 2020-08-27 15:18:18 PDT
Committed r266260: <https://trac.webkit.org/changeset/266260>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407337 [details].
Comment 5 Radar WebKit Bug Importer 2020-08-27 15:19:15 PDT
<rdar://problem/67900641>
Comment 6 Aakash Jain 2020-08-28 05:58:27 PDT
Restarted buildbot to pick up this change.