Summary: | Ensure that email notifications are not sent for obsolete and r- patches | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Aakash Jain
2020-08-26 13:57:13 PDT
Created attachment 407337 [details]
Patch
Comment on attachment 407337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407337&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:549 > + self._addToLog('stdio', 'Skipping email since patch {} is marked r-'.format(patch_id)) Do we have a request somewhere to make this the behavior when a patch is marked r-? It's not obviously that an r- ed patch shouldn't generate notification emails. (In reply to Jonathan Bedard from comment #2) > Do we have a request somewhere to make this the behavior when a patch is marked r-? It's not obviously that an r- ed patch shouldn't generate notification emails. Not an explicit request. Although marking r- itself generate an email notification from bugzilla. Committed r266260: <https://trac.webkit.org/changeset/266260> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407337 [details]. Restarted buildbot to pick up this change. |