Bug 215867 – Ensure that email notifications are not sent for obsolete and r- patches

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

We should ensure that email notifications are not sent for obsolete and r- patches. EWS does check occasionally if the patch is obsolete/r- and stops processing the build if so. However, there aren't checks at the end of the build. If the patch becomes obsolete/r- after EWS checks the patch state, it is possible that EWS might send email notification for the failure. We should add another check just before sending the email, to ensure that EWS doesn't send email for obsolete/r- patches. 

Note that it should be fine to send email for bugs which are closed, since it might indicate that there was a failure on the patch which was landed.

[Aakash Jain]

Created attachment 407337 [details]
Patch

[Jonathan Bedard]

Comment on attachment 407337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407337&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:549
> +            self._addToLog('stdio', 'Skipping email since patch {} is marked r-'.format(patch_id))

Do we have a request somewhere to make this the behavior when a patch is marked r-? It's not obviously that an r- ed patch shouldn't generate notification emails.

[Aakash Jain]

(In reply to Jonathan Bedard from comment #2)
> Do we have a request somewhere to make this the behavior when a patch is marked r-? It's not obviously that an r- ed patch shouldn't generate notification emails.
Not an explicit request. Although marking r- itself generate an email notification from bugzilla.

[EWS]

Committed r266260: <https://trac.webkit.org/changeset/266260>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407337 [details].

[Radar WebKit Bug Importer]

<rdar://problem/67900641>

[Aakash Jain]

Restarted buildbot to pick up this change.