Summary: | [JSC] Implement Intl.DateTimeFormat fractionalSecondDigits | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 213425 | ||||||||
Attachments: |
|
Description
Yusuke Suzuki
2020-08-25 23:21:02 PDT
This looks like about to be landed. We should support it. Created attachment 407277 [details]
Patch
Comment on attachment 407277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407277&action=review Easy-peasy! :) > Source/JavaScriptCore/builtins/DatePrototype.js:52 > + options.fractionalSecondDigits == @undefined ===, right? > Source/JavaScriptCore/builtins/DatePrototype.js:168 > + options.fractionalSecondDigits == @undefined Ditto. > JSTests/stress/intl-datetimeformat.js:704 > + "fractionalSecondDigits", nit: Indentation is off here (and also further above), though it doesn't matter much in a test file. Comment on attachment 407277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407277&action=review Thanks! >> Source/JavaScriptCore/builtins/DatePrototype.js:52 >> + options.fractionalSecondDigits == @undefined > > ===, right? Oops! Thanks. >> Source/JavaScriptCore/builtins/DatePrototype.js:168 >> + options.fractionalSecondDigits == @undefined > > Ditto. Fixed. >> JSTests/stress/intl-datetimeformat.js:704 >> + "fractionalSecondDigits", > > nit: Indentation is off here (and also further above), though it doesn't matter much in a test file. Fixed. Created attachment 407281 [details]
Patch
Patch for landing
Committed r266170: <https://trac.webkit.org/changeset/266170> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407281 [details]. |