Implement DataTransfer constructor and multipart form filename encoding as other browsers do

• Component: New Bugs
• Status: RESOLVED FIXED

[Alex Christensen]

Implement DataTransfer constructor and multipart form filename encoding as other browsers do

[Alex Christensen]

Created attachment 407270 [details]
Patch

[Alex Christensen]

Created attachment 407271 [details]
Patch

[youenn fablet]

imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/submit-file.sub.html needs to be updated.

[Alex Christensen]

Created attachment 407306 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[youenn fablet]

Comment on attachment 407306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407306&action=review

> Source/WebCore/dom/DataTransfer.cpp:97
> +    dataTransfer->m_effectAllowed = "none";

It is a bit sad to set it to none while we are initialising it to uninitialised.
Can we change DataTransfer constructor?

> Source/WebCore/platform/network/FormDataBuilder.cpp:179
> +    appendQuoted(buffer, encoding.encode(filename, UnencodableHandling::Entities));

Do we have test coverage?

> LayoutTests/imported/w3c/web-platform-tests/html/editing/dnd/datastore/datatransfer-types-expected.txt:3
> +FAIL Relationship between types and items assert_equals: expected ["text/plain"] but got ["text/plain"]

This error seems strange, we got what we expect so why are we failing?

> LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/submit-file.sub.html:7
> +<form id=testform method=post action="/html/semantics/forms/form-submission-0/resources/file-submission.py" target=testframe enctype="multipart/form-data">

Might be better to use http://{{hosts[alt][]}}:{{ports[http][0]}}
That way we keep cross origin posting which might be useful for the test.

We will need to upload this change to WPT as well.
If you use webkit-patch upload, it might allow you to automate the process and I can merge the changes in WPT.

[Alex Christensen]

(In reply to youenn fablet from comment #6)
> > Source/WebCore/platform/network/FormDataBuilder.cpp:179
> > +    appendQuoted(buffer, encoding.encode(filename, UnencodableHandling::Entities));
> 
> Do we have test coverage?
Yes.  This is what makes the send-file-form-{encoding}.html tests pass.

> > LayoutTests/imported/w3c/web-platform-tests/html/editing/dnd/datastore/datatransfer-types-expected.txt:3
> > +FAIL Relationship between types and items assert_equals: expected ["text/plain"] but got ["text/plain"]
> 
> This error seems strange, we got what we expect so why are we failing?
As noted in the changelog, I think it's expecting === and it is only ==.  I tried tinkering with it for a while, but couldn't get it quite right in a simple patch.

[Alex Christensen]

Created attachment 407314 [details]
Patch

[Alex Christensen]

Created attachment 407325 [details]
Patch

[EWS]

Committed r266187: <https://trac.webkit.org/changeset/266187>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407325 [details].

[Radar WebKit Bug Importer]

<rdar://problem/67826601>